[STORM-937] Path to python in /scripts/*.py file inconsistent - Second Life Bug Tracker

XML

Word

Printable

JSON

Details

Type: Defect
Status: Closed
Priority: Trivial
Resolution: Fixed
Affects Version/s: Viewer 2.6.0
Fix Version/s: Sprint 11
Labels:
None
Environment:
All

Approvals:

Code Review, Product Owner
Test Plan:
Hide

This is a build and test script change. If one of those was to fail, the build would fail miserably. So the test plan is "does it build on all platforms?":

For all platforms: download and install build

Launch and Login
-> Verify the viewer is fine
Show
This is a build and test script change. If one of those was to fail, the build would fail miserably. So the test plan is "does it build on all platforms?": For all platforms: download and install build Launch and Login -> Verify the viewer is fine

Description

The first line of python files in the scripts folder uses 2 different forms:
#!/usr/bin/python
or
#!/usr/bin/env python

The first form doesn't work for instance in my cygwin install since I didn't install python there. The second is more flexible but requires the PATH to be specified.

I'm not advocating one vs the other really (though I do prefer the 2nd one) but I think some consistency would prevent devs to bump into unexpected problems. I'm wondering if sldev developers have any opinion on this one.

FWIW, indra/develop.py (likely the most used python script) is using the 2nd form.

Attachments

Activity

People

Assignee:: Unassigned

Reporter:: Merov Linden

Prod Owner Approved:: Oz Linden

Watchers:: 2 Start watching this issue

Dates

Created:: 27/Jul/09 2:31 PM

Updated:: 19/Apr/11 2:25 PM

Resolved:: 12/Apr/11 4:40 PM

Time Tracking

Estimated:

Not Specified

Remaining:

Logged: