Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-863

Using --login on command line silently fails if new TOS needs accepting

    XMLWordPrintableJSON

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Viewer 2.4.0
    • Fix Version/s: Sprint 10
    • Labels:
      None
    • Environment:
      Windows 7 64-bit
      Second Life 2.4.0 (216989) Dec 15 2010 06:48:45 (Second Life Release)
    • Approvals:
      Code Review, Product Owner
    • Test Plan:
      Hide

      Permutations to verify:

      • Login with --login FIRST LAST PASSWORD on account that has subsequent login dialogs
      • Login with --login FIRST LAST PASSWORD on account w/o subsequent login dialogs
      • Login with --autologin on account that has subsequent login dialogs
      • Login with --autologin on account w/o subsequent login dialogs
      • Login with manual credentials on account that has subsequent login dialogs
      • Login with manual credentials on account w/o subsequent login dialogs

      The affected login dialogs are:

      • TOS acceptance (see bug description for how to tweak an account to require this)
      • Critical message (would require a DB update)
      • Optional viewer update (a notification mechanism that Linden doesn't currently use)
      • A mandatory update

      All of these require some amount of grid tinkering to achieve.

      Show
      Permutations to verify: Login with --login FIRST LAST PASSWORD on account that has subsequent login dialogs Login with --login FIRST LAST PASSWORD on account w/o subsequent login dialogs Login with --autologin on account that has subsequent login dialogs Login with --autologin on account w/o subsequent login dialogs Login with manual credentials on account that has subsequent login dialogs Login with manual credentials on account w/o subsequent login dialogs The affected login dialogs are: TOS acceptance (see bug description for how to tweak an account to require this) Critical message (would require a DB update) Optional viewer update (a notification mechanism that Linden doesn't currently use) A mandatory update All of these require some amount of grid tinkering to achieve.

      Description

      Repro:

      1. Arrange to have an account that needs to accept an updated TOS. This can be done (by a Linden, obviously) on a dev grid by setting user.tos_last_accept to a date in the past, e.g.

        UPDATE user SET tos_last_accept = '1970-01-01T00:00:00' WHERE agent_id = '...';

      2. Tell the viewer to log in; on Windows:

        SecondLife.exe --login FIRST LAST PASSWORD

      Expected:

      Viewer shows TOS acceptance dialog, then proceeds with login

      Actual:

      Viewer shows the login screen, with the username/password pre-filled, but no indication of why --login didn't do what was expected.

      Background:

      When a TOS agreement is required, the login process fails the login with a reason of "tos"; the viewer is then intended to show the TOS and, on accept, re-submit the login indicating that the new TOS has been accepted. Bypassing the credential-entry screen must put the login process into an odd state on this failure.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            joshua.linden Joshua Linden (Disable)
            Extended Group Visibility:
            jira-users
            Prod Owner Approved:
            Oz Linden Oz Linden
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: