Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-825

Reenable the LLMatrix3::orthogonalize test in llmath/tests/m3math_test.cpp

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Sprint 9
    • Fix Version/s: Sprint 9, Viewer 2.5.0
    • Labels:
      None
    • Environment:
      All/Building from source code
    • Approvals:
      Code Review, Product Owner
    • Test Plan:
      Hide

      This is a unit test. The code is ran only at build time. Test is therefore: does it build?

      Show
      This is a unit test. The code is ran only at build time. Test is therefore: does it build?

      Description

      The Unit test in llmath/tests/m3math_test.cpp for llmatrix3::orthogonalize is skiped with a comment "Grr, LLMatrix3::orthogonalize test is failing. Has it ever worked?", it not only appears to work fine and pass the test on Linux and Windows so far, the skip() is causing a "Unreachable code" error on visual studio which causes that test to fail to compile at all.

      Please also see discussion and (1 line patch) at http://www.mail-archive.com/opensource-dev@lists.secondlife.com/msg04046.html

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              robin.cornelius Robin Cornelius
              Extended Group Visibility:
              jira-users
              Prod Owner Approved:
              Oz Linden
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h