Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-439

[VWR-23239] Memory leak in LLUIString

    XMLWordPrintableJSON

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Viewer 2.1.2
    • Fix Version/s: Sprint 6, Viewer 2.3.0
    • Labels:
      None
    • Environment:
      C++, a programming language without garbage collection
    • QA Status:
      Fixed - On Review

      Description

      (Originally posted on opensource-dev)

      Changeset 80af8db446df changes LLUIString::mArgs into a pointer. This pointer gets initialized with a new object in one of the constructors (the other constructors set it to NULL), or lazily (i.e. when still NULL when an actual object is required) through LLUIString::getArgs().

      It looks like mArgs never gets deleted again, so it is probably being leaked.

      As far as I can see, mArgs (which is private) doesn't get assigned any pointers from outside the LLUIString instance and is never passed out through any method, so it should be save to delete it in the (yet unwritten) destructor of LLUIString.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            boroondas.gupte Boroondas Gupte
            Extended Group Visibility:
            jira-users
            Prod Owner Approved:
            Merov Linden
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 15 minutes
                1h 15m

                  PagerDuty