Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-2141

Various issues regarding inventory floater

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Unset
    • Resolution: Released
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Test Plan:
      Hide

      Test according to bug reproduction steps.

      Show
      Test according to bug reproduction steps.

      Description

      Due to the existence of legacy inventory floater code (LLFloaterInventory), this has led to a few issues in the current inventory floater handling. These are:

      • Opening new inventory via Control-Shift-I shortcut uses the legacy and potentinally dangerous code path since it calls LLFloaterInventory::showAgentInventory, which will always return NULL even though the inventory floater has been opened
      • Closing new (secondary) inventory windows will never release memory and cause a memory leak as such; can be easily noticed by enabling Develop -> Show info -> Show memory
      • During shutdown legacy and inoperable code for inventory window cleanup is called

      Fixes for mentioned issues are available at https://bitbucket.org/Ansariel/storm-2141/commits/7e363b1f0b7f1b9353f7cb6190c4f72e88a7b8e5 . The changeset additionally removes the old legacy inventory window code, that isn't working anymore.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              ansariel.hiller Ansariel Hiller
              Contributor:
              Ansariel Hiller
            • Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: