Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-2122

UDP data bandwith measuring is off by factor 8

    XMLWordPrintableJSON

    Details

    • Type: Defect
    • Status: Pending Release
    • Priority: Unset
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Environment:

      Description

      Since the release of the project interesting viewer, the (statistic) value for UDP data bandwith is calculated wrong and off by factor 8.

      Repro:

      • Login into a fairly constant region and wait until everything has loaded
      • Open the statistics floater and notice the statistic "UDP Data Received"
      • Open the Windows resource monitor and check how much data is actually being transferred by the viewer process
      • Notice that the value in the statistics floater is off roughly by the factor 8

      This is caused by old pre-interesting code in LLViewerRegion, where the amount of incoming bytes is converted into bits by multiplying with the factor 8. However, with the introduction of LLUnits, they will take care of the correct conversion themselves, thus explicitly multiplying by 8 will cause the already converted values multiplied a second time and be wrong.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              ansariel.hiller Ansariel Hiller
              Contributor:
              Ansariel Hiller
            • Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: