Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-1942

Cocoa project viewer: dock icon bouncing unimplemented

    XMLWordPrintableJSON

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Minor
    • Resolution: Released
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Environment:
      Cocoa project viewer
    • Patch attached:
      Patch attached

      Description

      Dock icon bouncing in the Cocoa viewer is unimplemented and should be reimplemented. I have attached a patch that does so.

      In this patch I have chosen to disregard the number of seconds to bounce for passed in, instead opting to conform to the OS X UI standards, which leave it for the OS to decide how long to bounce the icon for (at this time, for one second).

      It is also preferable to do this regardless of whether the window is minimised – again, on OS X the expected behaviour is to bounce unless the window actually has focus, which is checked by the OS itself. To achieve this I have performed a very minor refactor of this function call elsewhere. Specifically, I have pushed the getMinimized() check down from llviewermessage.cpp into LLWindowSDL::flashIcon and LLWindowWin32::flashIcon.

      In the likely event this is deemed unacceptable I have also provided an arguably incorrect patch without this refactor (bouncing-icons-without-refactor.patch), but I do not recommend using it.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            katharine.berry Katharine Berry
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                PagerDuty