Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-1817

standards C++ use of implied default constructors

    XMLWordPrintableJSON

    Details

    • Type: Defect
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: Open Development Candidates
    • Fix Version/s: None
    • Labels:
      None
    • Environment:
      opensource hg repository: 22479 (e9dd1416d96a) increment viewer version to 3.3.1
    • Release Vehicles/Components:
      Viewer - Source Code

      Description

      Various files use a non-standards-compliant construct for initialization with implied default constructors. VC++, GCC<4.4 and GCC>4.6 appear to allow SL's use, but it is still arguably more correct to fix (as well as fully compatible).

      An example of the error in question under GCC-4.6 looks like:

      viewer-development/indra/newview/llplacesinventorypanel.cpp:42:45: error: uninitialized const 'PLACES_INVENTORY_BUILDER' [-fpermissive]
      viewer-development/indra/newview/llplacesinventorybridge.h:85:7: note: 'const class LLPlacesInventoryBridgeBuilder' has no user-provided default constructor
      

      The attached patch proposes a simple fix for the cases that block the compile.

      FWIW, here's a GCC bug report that discusses the situation http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44499

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            vex.streeter Vex Streeter
            Extended Group Visibility:
            jira-users
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                PagerDuty