Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-1787

Some dead code in build.sh which throws an uncaught error.

    XMLWordPrintableJSON

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Minor
    • Resolution: Released
    • Affects Version/s: None
    • Fix Version/s: Active
    • Labels:
      None
    • Environment:
      -
    • Acceptance Criteria:
      The build script does not attempt to populate an unused build_viewer_update_version_manager_version variable, and does not attempt to run a non-existent get_version.py file.

      Description

      In build.sh, there is a variable that never gets used. There is only an attempt to populate it by calling a non-existent python file, scripts/get_version.py. A failure shows in the build log, but doesn't fail the build, but merely causes noise in the log.

      https://bitbucket.org/lindenlab/viewer-development/src/34d957a19aa4/build.sh#cl-135

      Dead code in build.sh

      # Now retrieve the version for use in the version manager
      # First three parts only, $revision will be appended automatically.
      build_viewer_update_version_manager_version=`python scripts/get_version.py --viewer-version | sed 's/\.[0-9]*$//'`
      

      Failure message in the build log.
      C:\Python25\python.exe: can't open file 'scripts/get_version.py': [Errno 2] No such file or directory

      As far as I can tell, build_viewer_update_version_manager_version, does not get used anywhere. So, the 3 lines can be safely removed.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            spider.linden Spider Linden
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                PagerDuty