Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-1734

[VWR-27832] L$ Transfer failures show alert as if successful

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Unset
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Active
    • Labels:
      None
    • Environment:
    • Test Plan:
      Hide

      With an account that has less than L$10,000
      Rez a cube
      Put the attached script Pay.lsl into it
      Click Grant on the notification that appears
      Close the build floater
      Click on the cube: You receive a notification "You failed to pay <your name> L$10000."

      Show
      With an account that has less than L$10,000 Rez a cube Put the attached script Pay.lsl into it Click Grant on the notification that appears Close the build floater Click on the cube: You receive a notification "You failed to pay <your name> L$10000."

      Description

      When a L$ transaction fails for some reasons (insufficient funds, unknown destination agent) the viewer still shows an alert as if the transaction succeeded, even though it did not.

      Repro:

      • Use LSL llGivMoney to pay out more than the amount of L$ you own.

      Expected:

      • The viewer shows an error message indicating the transaction failed due to insufficient funds.

      Seen:

      • Currently the server (as of 12/12/2011 all released servers) sends a message that causes the viewer to reset the displayed balance to L$-1. This is bad, but a different bug and fixing it causes the next item:
      • The viewer pops up an alert that says "You paid Foo Bar L$1234" as if it had succeeded.

      Technical details:
      The server sends down a MoneyBalanceReply message. This message includes TransactionSuccess which the server correctly sets to FALSE for failed transactions. The viewer however ignores this in newview/llviewermessage.cpp in both process_money_balance_reply and process_money_balance_reply_extended. The viewer should NOT ignore this value and display an appropriate message when a transaction fails. This was masked previously due to a server bug that is being fixed.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                peqa.team PEQA Team
                Reporter:
                kelly.linden Kelly Linden
                Extended Group Visibility:
                jira-users
              • Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: