Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-1718

For notifications.xml Mute and Ignore in ScriptDialog and ScriptDialogGroup can collide with user-supplied fields causing unexpected behavior

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Major
    • Resolution: Released
    • Affects Version/s: Open Development Candidates
    • Fix Version/s: Active
    • Labels:
      None
    • Environment:
    • Approvals:
      Code Review
    • Test Plan:
      Hide

      Rezz a cube
      Put the attached script DialogButtons.lsl into it
      Take a copy of the cube into inventory

      Click on each button in turn
      For each of the dialog buttons you should see the name of the button you just clicked on appear as text above the cube

      The buttons at the bottom, Block and Ignore, should work as they usually do.

      Move to some group owned parcel where you are a member of that group
      Activate the group
      Rezz the cube you took a moment ago
      In the Build floater deed it to group
      Repeat the click on each button tests

      Show
      Rezz a cube Put the attached script DialogButtons.lsl into it Take a copy of the cube into inventory Click on each button in turn For each of the dialog buttons you should see the name of the button you just clicked on appear as text above the cube The buttons at the bottom, Block and Ignore, should work as they usually do. Move to some group owned parcel where you are a member of that group Activate the group Rezz the cube you took a moment ago In the Build floater deed it to group Repeat the click on each button tests

      Description

      In notifications.xml under ScriptDialog and ScriptDialogGroup there are entries
      name="Mute"
      name="Ignore"

      If a script defines buttons in a dialog box using one of these names and the dialog button is pressed the script does not receive notification of the button press. Instead, the viewer misinterprets the button press as an internal Mute or Ignore operation.

      Changing the name= field to something that would not normally be used to name a button in a dialog box makes this much less likely to occur.

      Change:
      name="Mute" to name="Client_Side_Mute" and
      name="Ignore" to name="Client_Side_Ignore"

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jonathan.yap Jonathan Yap
              Extended Group Visibility:
              jira-users
            • Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: