Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-1717

Inspect floater does not show correct names on first open

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Active
    • Labels:
    • Environment:

      Description

      Whenever the inspect floater is opened the first time for an object for that not all owner/creator names of the individual prims are known, the floater displays the wrong names. It usually shows the first name that gets retrieved from the avatarname cache for the owner and creator for all prims of the object. If the inspect floater is opened another time for the same object, it shows the correct names. Reason for this behavior is, that the names are retrieved via LLAvatarNameCache::get() method and the result is used without checking if the correct name was actually retrieved or is available yet. The second time the floater is opened for an object this works because the names are already in the local name cache and available instantly.

      Repro steps:
      1. Go to some place with objects from residents whose name is not in the local display name cache.
      2. Right click on any object, select object profile. On the object profile, click on the details button in the sidebar to bring up the inspect floater.
      3. While having the inspect floater open, select any other object around of a resident whose name is also not in the cache. You will notice one and the same name is shown for every prim as creator and owner.
      4. While still having the inspect floater open, select a different object and then the previous object again. Now you will notice it shows completely different, but correct names.

      I attached a patch with a fix I made for Firestorm. It was tested against revision 19111 of the Snowstorm repository.

        Attachments

        1. FirstOpen.png
          FirstOpen.png
          2.10 MB
        2. InspectFloaterNamesFix.patch
          3 kB
        3. inspect objects_noncached names.png
          inspect objects_noncached names.png
          67 kB
        4. SecondOpen.png
          SecondOpen.png
          1.98 MB

          Activity

            People

            • Assignee:
              productengine.team ProductEngine Team
              Reporter:
              ansariel.hiller Ansariel Hiller
              Extended Group Visibility:
              jira-users
            • Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: