Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-1532

[VWR-25923] Unnecessary capability request spam

    XMLWordPrintableJSON

    Details

    • Type: Story
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Sprint 19
    • Labels:
    • Environment:
    • Test Plan:
      Hide

      0. activate the Voice tag in logcontrol.xml and have a console window open to be able to see the relevant parts, make sure at the grid status page that there are no known networking or voice issues

      1. Login to a region with ParcelVoiceInfoRequest capability, make sure voice works normal (both spatial, and direct call/conference)
      a) if there are no regions without ParcelVoiceInfoRequest capability in SL:
      2. check that after region crossing and teleporting voice works normal (see 1.)

      b) if there are regions without ParcelVoiceInfoRequest capability in SL (maybe a beta grid, testing future functionality):

      2. teleport to a region without ParcelVoiceInfoRequest capability, make sure spatial voice gets disabled, and the console doesn't get spammed with "sending ParcelVoiceInfoRequest " debug messages.
      3. teleport again to a region with ParcelVoiceInfoRequest capability, make sure voice activates again (see 1).
      4. repeat step 1-3, this time starting at a region without capability, tp to region with capability and back to region without.

      Show
      0. activate the Voice tag in logcontrol.xml and have a console window open to be able to see the relevant parts, make sure at the grid status page that there are no known networking or voice issues 1. Login to a region with ParcelVoiceInfoRequest capability, make sure voice works normal (both spatial, and direct call/conference) a) if there are no regions without ParcelVoiceInfoRequest capability in SL: 2. check that after region crossing and teleporting voice works normal (see 1.) b) if there are regions without ParcelVoiceInfoRequest capability in SL (maybe a beta grid, testing future functionality): 2. teleport to a region without ParcelVoiceInfoRequest capability, make sure spatial voice gets disabled, and the console doesn't get spammed with "sending ParcelVoiceInfoRequest " debug messages. 3. teleport again to a region with ParcelVoiceInfoRequest capability, make sure voice activates again (see 1). 4. repeat step 1-3, this time starting at a region without capability, tp to region with capability and back to region without.

      Description

      Ways to reproduce: log into a simulator.
      Reproduces: always
      Affects: any version supported, probably all 3rd party viewers but Kokua (and Imprudence, soon).

      What happens:
      In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" capability, thats each time a HTTP GET.
      See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel boundary crossing

      Expected:
      On parcel/region change request the capability once. It's not the region that rezzes in, but the avatar, so do the request for the capability not earlier than the agents region signals capabilitiesReceived() true. After that you are sure if the region returns an empty url you can give up for that region.

      Not sure about the impact on lag - requesting and returning an url is not much data transmitted, though its a pretty big number of people doing it over and over per second (no matter if they have voice on or off).

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            arminweatherhax ArminWeatherHax
            Extended Group Visibility:
            jira-users
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                PagerDuty