Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-1397

[VWR-26066] Opening the map floater consistently produces a warning on stdout and debug console.

    XMLWordPrintableJSON

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: Viewer 2.4.0, Viewer 2.7.1
    • Fix Version/s: None
    • Labels:
      None
    • Environment:
    • QA Status:
      Fixed - On Review
    • Approvals:
      Code Review, Product Owner
    • Test Plan:
      Hide

      1. Start the viewer from a terminal, or make the debug console visible after logging in
      2. Open the map e.g. by pressing Ctrl-m or by clicking the Map button (can be made visible from the bottom bar context menu)

      • Verify that no warning occured about child "zoom slider" being of wrong type
      Show
      1. Start the viewer from a terminal, or make the debug console visible after logging in 2. Open the map e.g. by pressing Ctrl-m or by clicking the Map button (can be made visible from the bottom bar context menu) Verify that no warning occured about child "zoom slider" being of wrong type
    • Root Cause:
      Viewer - Viewer

      Description

      To reproduce

      1. Start the viewer from a terminal, or make the debug console visible after logging in
      2. Open the map e.g. by pressing Ctrl-m or by clicking the Map button (can be made visible from the bottom bar context menu)

      Expected

      • Map opens
      • Debug console or terminal displays

        INFO: openFloater: Opening floater worldmap

        (and no warning)

      Observed

      • Map opens
      • Debug console or terminal displays

        INFO: openFloater: Opening floater worldmap
        WARNING: getChild: Found child named "zoom slider" but of wrong type 12LLSliderCtrl, expecting P8LLSlider

      Diagnosis

      void LLFloaterWorldMap::adjustZoomSliderBounds() looks for a XUI element named "zoom slider" amongst the LLFloaterWorldMap's children but assumes the element is of (C++) type LLSlider. There is a child element named "zoom slider", but it is a slider XUI element, which gets mapped to C++ type LLSliderCtrl. Altough LLSliderCtrl is allegedly a decorator for LLSlider, it can't be casted to the latter, thus why we're seeing the warning message.

      Possible solution

      LLSliderCtrl::setMinValue(F32) does forward calls to LLSlider::setMinValue(F32), so requesting the child element as LLSliderCtrl should result in the intended behavior without causing a warning.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              boroondas.gupte Boroondas Gupte
              Extended Group Visibility:
              jira-users
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: