Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-1130

Top Scripts/Colliders: Date/time sorting is broken (sorts lexically)

    XMLWordPrintableJSON

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: viewer-development
    • Fix Version/s: None
    • Labels:
      None
    • Environment:
      -
    • Approvals:
      Code Review, Product Owner
    • Acceptance Criteria:
      Sorting by date is actually useful per the repro instructions.
    • Test Plan:
      Hide

      Note that the fix affects both "Top Scripts" and "Top Colliders". Both should be tested

      1. Log in
      2. Go to a region you control (or if you're a Linden, use God mode)
      3. World menu > Place Profile > Region/Estate
      4. Debug tab
      5. Click "Get Top Scripts..." or "Get Top Colliders..."
      6. Click on the Time column

      • Verify that date/times sort in ascending or descending order correctly
      • Verify that date/times are still human readable and include all necessary components (year/month/day/hour/minute) (NOTE: may include more e.g. day of week, that's okay)
      • Verify that sorting other columns still works correctly
      • Verify that behavior with a mix of scripts compiled for Mono and not
      Show
      Note that the fix affects both "Top Scripts" and "Top Colliders". Both should be tested 1. Log in 2. Go to a region you control (or if you're a Linden, use God mode) 3. World menu > Place Profile > Region/Estate 4. Debug tab 5. Click "Get Top Scripts..." or "Get Top Colliders..." 6. Click on the Time column Verify that date/times sort in ascending or descending order correctly Verify that date/times are still human readable and include all necessary components (year/month/day/hour/minute) (NOTE: may include more e.g. day of week, that's okay) Verify that sorting other columns still works correctly Verify that behavior with a mix of scripts compiled for Mono and not
    • Root Cause:
      Viewer - Viewer
    • Release Vehicles/Components:
      Viewer - Viewer

      Description

      The Top Scripts and Top Colliders dialogs show the date/time when an object was added to the sim. This is useful for land owners (and support) to diagnose server performance issues. Often, a region has been running just fine for several months and suddenly is laggy as a result of a newly added script. Identifying those scripts is critical.

      Unfortunately, the field shows date/times like "Wed Sep 30 16:01:02 2009" and the field sorts lexically, so e.g. all scripts started on Friday bubble to the top, regardless of what day, month, or year they started!

      Repro:
      1. Log in
      2. Go to a region you control (or if you're a Linden, use God mode)
      3. World menu > Place Profile > Region/Estate
      4. Debug tab
      5. Click "Get Top Scripts..." (or "Get Top Colliders...")
      6. Click on the Time column

      Expected:
      Dates sort in ascending/descending order by date

      Actual:
      Dates sort like text strings (all "Fri" grouped together, etc)

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            joshua.linden Joshua Linden (Disable)
            Prod Owner Approved:
            Oz Linden Oz Linden
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                PagerDuty