Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-1073

Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

    XMLWordPrintableJSON

    Details

    • Approvals:
      Code Review, Product Owner
    • Acceptance Criteria:
      This is strictly a build change and has influence only on folks using cmake versions older than 2.8.2 (hence, not exercised by our TC build machines). Acceptance is limited to "does it build"...

      Description

      In 14319:9e99b2c8fb28 and descendants, pkg_check_modules is passed the QUIET option for all CMake versions >=2.8, but it won't work before version 2.8.2. Instead, e.g. on 2.8.1, one will get

      -- checking for modules 'libllqtwebkit;QUIET'
      --   package 'libllqtwebkit' not found
      --   package 'QUIET' not found

      during configuration, when there is no .pkg file for libllqtwebkit.

      Without QUIET, the output would be just

      -- checking for module 'libllqtwebkit'
      --   package 'libllqtwebkit' not found

      on the same system.

      (Suppressing even that output is the intention of using QUIET on CMake versions that support it, as we'll search for llqtwebkit in another way, so not finding it here isn't fatal nor unusual.)

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              boroondas.gupte Boroondas Gupte
              Extended Group Visibility:
              jira-users
              Prod Owner Approved:
              Merov Linden
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: