Uploaded image for project: 'Snowstorm'
  1. Snowstorm
  2. STORM-1059

Possible crash on llassert_always(purge_list.size() >= entries_to_purge);

    XMLWordPrintableJSON

    Details

    • Type: Defect
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Sprint 12
    • Labels:
      None
    • Environment:
      all
    • Approvals:
      Code Review, Product Owner
    • Test Plan:
      Hide

      There is no behavior change visible. The only difference will be under texture purging conditions, the new code avoiding a potential crash through llassert_always().

      Test should be about regression texture cache testing: clear cache, move around world and see the cache grow at a healthy clip, move around till it hits purge condition, see it doesn't behave strangely.

      Show
      There is no behavior change visible. The only difference will be under texture purging conditions, the new code avoiding a potential crash through llassert_always(). Test should be about regression texture cache testing: clear cache, move around world and see the cache grow at a healthy clip, move around till it hits purge condition, see it doesn't behave strangely.

      Description

      There is a bug in indra/newview/lltexturecache.cpp that I fixed before (for a TPV).
      It's just bad code that potentially can lead to a crash.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            aleric.inglewood Aleric Inglewood
            Extended Group Visibility:
            jira-users
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                PagerDuty