[STORM-1059] Possible crash on llassert_always(purge_list.size() >= entries_to_purge); - Second Life Bug Tracker

XML

Word

Printable

JSON

Patch attached:

Patch attached
Code Review:
https://codereview.secondlife.com/r/93/
Branch/Repo Fixed In:
https://bitbucket.org/merov_linden/viewer-development-storm-1059

Approvals:

Code Review, Product Owner
Test Plan:

Hide

There is no behavior change visible. The only difference will be under texture purging conditions, the new code avoiding a potential crash through llassert_always().

Test should be about regression texture cache testing: clear cache, move around world and see the cache grow at a healthy clip, move around till it hits purge condition, see it doesn't behave strangely.

Show
There is no behavior change visible. The only difference will be under texture purging conditions, the new code avoiding a potential crash through llassert_always(). Test should be about regression texture cache testing: clear cache, move around world and see the cache grow at a healthy clip, move around till it hits purge condition, see it doesn't behave strangely.

There is a bug in indra/newview/lltexturecache.cpp that I fixed before (for a TPV).
It's just bad code that potentially can lead to a crash.