Uploaded image for project: 'Open Development'
  1. Open Development
  2. OPEN-54

Inconsistent CMake variable name for JsonCpp include dir(s)

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Product Review
    • Priority: Trivial
    • Resolution: Fixed
    • Component/s: viewer build
    • Labels:
    • Environment:
      -
    • Approvals:
      Code Review
    • Acceptance Criteria:
      Hide
      0. Viewer still builds.
      1. If indra/cmake/FindJsonCpp.cmake finds the headers in a dir that isn't a default include dir, that dir is made an include dir.
      Show
      0. Viewer still builds. 1. If indra/cmake/FindJsonCpp.cmake finds the headers in a dir that isn't a default include dir, that dir is made an include dir.

      Description

      On standalone, indra/cmake/FindJsonCpp.cmake sets JSONCPP_INCLUDE_DIR. However indra/newview/CMakeLists.txt declares not the path(s) in that variable, but instead those in JSONCPP_INCLUDE_DIRS an include dir, although that variable isn't set on standalone. (On non-standalone, JSONCPP_INCLUDE_DIRS is set in indra/cmake/JsonCpp.cmake.

      So even when the JsonCpp headers are found alright, the corresponding dir isn't used as an include dir. Even on standalone, this didn't have any effect most of the time, because that dir happened to be one of the default include dirs, which don't have to be explicitly passed for headers in them being found.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              boroondas.gupte Boroondas Gupte
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: