Uploaded image for project: 'Open Development'
  1. Open Development
  2. OPEN-52

Superfluous source files

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Reviewing
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • Does the Viewer still build and function on all operating systems with the files removed.

    Description

      I have had trouble in the past thinking a .cpp file does some work when in fact it has been abandoned in the source code tree.

      Part 1

      For indra\newview I did a diff between what is in cmakelists.txt and what is actually in the directory.

      Here are the files I found that were in the directory but not in cmakelists.txt:

      fmodwrapper.cpp
      llappviewerlinux.cpp
      llappviewerlinux_api_dbus.cpp
      llappviewermacosx.cpp
      llappviewerwin32.cpp
      lldrawpoolclouds.cpp
      llfloaterchat.cpp
      llfloaterchatterbox.cpp
      llfloaterfriends.cpp
      llimpanel.cpp
      lloverlaybar.cpp
      llsrv.cpp
      lltoolbar.cpp
      lltoolview.cpp
      llviewerprecompiledheaders.cpp
      llwindebug.cpp
      llworldview.cpp
      

      I deleted all but llviewerprecompiledheaders.cpp and their corresponding .h file and tried compiling to see what might go wrong. It turns out two of those files are needed and other testers have been reporting back, so here is the current list:

       
       
       
       
       
      lldrawpoolclouds.cpp
      llfloaterchat.cpp
      llfloaterchatterbox.cpp
      llfloaterfriends.cpp
      llimpanel.cpp
      lloverlaybar.cpp
      llsrv.cpp
      lltoolbar.cpp
      lltoolview.cpp
       
       
      llworldview.cpp
      

      Part 2

      I also deleted llchatbar.* and the references to it in cmakelists.txt. This is dead code.

      After deleting these .cpp and .h files I had to fix up a few .cpp files that were including a now-deleted .h file.

      I did my testing on Windows and would like some testing done on Mac and Linux.

      With these files deleted I was able to compile, link, and run the viewer.

      Attachments

        Activity

          People

            Unassigned Unassigned
            jonathan.yap Jonathan Yap
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 4 hours
                1d 4h