Whirly Fizzle commented at 2015-05-22T16:50:44Z

When this happened, did the appearance panel fail to show that there were unsaved changes to the outfit? "Save" will be greyed out in this case.
I've seen this happen before but I don't have a repro unfortunately. I cannot reproduce it at will, it just happens randomly but often.
The appearance panel often fails to notice unsaved changes to an outfit and also, when they are no unsaved changes to an outfit, appearance panel will show there are unsaved changes.

If you can reproduce this 100% of the time, how are you adding the makeup?
eg) Are you adding the makeup (tattoo layer?) from inventory with Right click -> Add?

Roxie Torok commented at 2015-05-22T18:03:59Z

Whirly:

Here's the scenario I just verified.

1. Appearance Panel is open
2. Clicked the Wearing tab
3. Detached blond hair from the Wearing panel and hair came off as it should
4. Went to Inventory and added Red hair and Red hair showed up on Avatar as it should.
5. Appearance Panel Wearing tab does NOT show the red hair as unsaved (i.e. it is not in bold)
6. Only "Save As" button is available
7. Default name of outfit if click "Save As" is New Outfit (new)

I hope that helps. This happens 100% of the time since whatever update was don to 'fix' the Favorites and the Outfit folders. Used to be able to just Save and it replaced same named outfit with the change.
One thing, I had been using sub-folders in Outfits in the past and ALL of my outfits are currently in sub-folders.

I am going to create a new outfit, and save it without a sub folder and make the change as above and see what happens... brb :)

Okay, was able to save it now, so it's a sub-folder problem.

I guess my workaround will be to create that New Outfit folder after I make the change, delete everything in the old outfit folder that's still in the Sub-folder, Copy everything from the New Outfit folder I just made and Paste to the old empty folder I already had. Wow, that sounds convenient, doesn't it?

Roxie Torok

Whirly Fizzle commented at 2015-05-22T19:01:44Z

Ahhh yep.
There's all kinds of wonkiness now with the appearance panel behaviour if you have subfolders in your saved outfits.

There is a request to change the behaviour and allow outfit subfolders to be created again at BUG-9209

Vir Linden commented at 2015-08-06T18:46:58Z, updated at 2015-08-06T19:03:54Z

So far I'm not seeing the issue reported. Here's what I've tried:

• create an outfit

• drag it to a subfolder of My Outfits (note that viewer-release does not allow this, so I used an internal development build with a fix for the drag to subfolder issue. This is already tracked in another JIRA)

• Start the release viewer. The outfit that was moved to the subfolder does show up in the outfits list of the appearance panel, even though it lives in a subfolder.

• From the appearance panel, wear the subfolder outfit. Appearance panel shows "Now wearing..." with the name of the outfit. "Save" is disabled for the outfit - expected behavior since there are no changes yet.

• Add a hairpiece (attachment) to the avatar. Appearance panel now shows "Unsaved changes"

• The newly added item also shows in the wearing tab of the appearance panel. It's not bolded, but I don't see that things are ever shown bolded there.

• "Save" is now enabled for the outfit.

• If you click "Save", the outfit is updated and continues to live in the subfolder. Outfit now shows "Wearing" instead of "Unsaved changes".

  So presumably there's something different about my test case. Can anyone comment? Does this sequence of steps work for you? Is it possible someone is using folders that are not true outfits (ie, just folders full of items rather than links, or not flagged as an outfit? Note that a true outfit will show with a clothes hanger icon in inventory.

Vir Linden commented at 2015-08-06T19:02:46Z

If you need a build that will allow you to drag an outfit into a subfolder of My Outfits, you can use:
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/maint_viewer-lion/rev/304126/index.html

Whirly Fizzle commented at 2015-08-07T02:06:47Z, updated at 2015-08-07T02:09:27Z

Is it possible someone is using folders that are not true outfits (ie, just folders full of items rather than links, or not flagged as an outfit? Note that a true outfit will show with a clothes hanger icon in inventory.

Very possible.
You can create outfit folders that are not true outfits on viewer Lion too.

I created a new folder within normal inventory called "Test additions" and placed 2 objects inside it.
Then I dragged the "Test additions" folder into the My Outfits folder.
The Test additions folder was moved into My Outfits, the Test additions folder is not a "real" outfit folder (it has no coathanger icon) and the objects within the Test additions folder are not links, it is copies of the actual objects.
See http://prntscr.com/81ra2p

I don't know if this is supposed to be expected behaviour or not.

Tested on http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/maint_viewer-lion/rev/304126/index.html

Also to note - the Test additions folder shows up as a saved outfit in appearance panel: http://prntscr.com/81rb7p

Whirly Fizzle commented at 2015-08-07T02:27:36Z, updated at 2015-08-07T02:28:29Z

@vir, can you write a doc to explain how the new behaviour is supposed to work in Lion?
Theres some quirks that I dont know if they are expected behaviour or bugs.

There's definitely some bugs though, like the appearance panel getting stuck on "Changing Outfits..." when replacing outfit with an outfit folder containing a subfolder.
See http://prntscr.com/81rfan

To reproduce the above example:

• Replace outfit with a saved outfit, Folder B listed in My Outfits. (Folder B is a "real" outfit folder).

• Create a folder - Folder A - containing 2 objects and drag this folder into My Outfits folder.

• Note when Folder A is moved into My Outfits, it does not have a coathanger icon and the objects inside it are not links.

• Drag Folder A inside an already saved real outfit folder - Folder B.

• Right click Folder B -> Replace Outfit

• Appearance panel hangs forever on "Changing Outfits..." & the loading cursor spins constantly.

  Is it too early to file bugs for Lion?

Whirly Fizzle commented at 2015-08-07T06:32:09Z, updated at 2015-08-07T06:39:31Z

Okay I can reproduce Roxie's original bug on both Viewer Lion and default release (Second Life 3.8.2 (303891) Jul 28 2015 12:10:43 (Second Life Release)) - to reproduce it on default release, you must already have subfolders within the outfits folder.

It's basically the same steps I gave above - when the appearance panel gets in that funky state of being stuck on "Changing Outfits..." or showing "No outfit" worn (one of the 2 behaviours will always happen when replaceing outfit with a folder containing subfolders, if you then make a change to that outfit, you cannot ever save those changes, the save button is greyed out.

So, Vir, if you do my repro steps above, then make a change to the outfit (add or remove one attachment say...) you should be able to reproduce Roxie's bug.
I can write details steps if you need.

This reproduced on default release: http://prntscr.com/81t38k

• I replaced outfit with Outfit A
• Then I replaced outfit with Outfit A additions (Outfit A is a subfolder of Outfit A additions).
• Appearance panel gets stuck with the loading icon spinning on the right & this doesnt ever stop until I replace with a "normal" outfit folder.
• I detatached "Object" from worn Outfit A additions.
• I attempted to save changes to Outfit A additions and Save is greyed out.

Vir Linden commented at 2015-08-07T13:42:07Z

viewer-lion just has a change to the folder dragging behavior, as far as I know. We are looking into what it would take to support some nesting uses more fully. Looks like there are a couple of different uses for nesting:

• For organizing a large number of outfits, it would be useful to allow outfits to live in subfolders, rather than requiring them to all be direct children of My Outfits.
• There also seems to be some interest in using subfolders inside an outfit, which is not the same use case, and would be harder to support. Could you comment on what the intended uses are for this type of nesting?

The intent with outfits was always that they would be internally flat - just a collection of links with no subfolders - although apparently that was not enforced consistently.

Whirly Fizzle commented at 2015-08-08T15:05:57Z

@vir

There also seems to be some interest in using subfolders inside an outfit, which is not the same use case, and would be harder to support. Could you comment on what the intended uses are for this type of nesting?

This issue is imported so comments are locked for most people.

I asked for use cases for subfolders inside an outfit on http://jira.phoenixviewer.com/browse/FIRE-15603 and I'll paste any feedback we get here.

One comment already:

Ferris Greymoon added a comment - 12 minutes ago

I'll add a few use cases that would be handy for me.

1 - The majority of my visible outfits are a body (ie, mesh body, legs, hands, head, jaw, hair) plus whatever clothing. The body is almost always the same. If I update that body, I have to go through all of my Outfits to make that update. If, instead, I could just change the referenced body nested-outfit (or linked outfit) that would save a lot of long-term hassle.

2 - My HUD is almost always the same things, plus or minus special huds for an an outfit item or location. If I update that HUD I have to go through all the outfits with that change. Again, having a referenced or nested outfit would be just one place to change.

3 - I keep Gestures in my Outfits. They're almost always the same as well, no matter what outfit. In one subtle case I accidentally created several redundant links to those Gestures, which was a lot to clear out. As with case 1 and 2, being able to edit just one referenced list of Gestures would be quite handy.

Thanks!

Vir Linden commented at 2015-08-10T14:35:56Z

Hey Whirly, thanks for talking to folks about that! Basically the way the system works today is that it expects the outfit folders to be interchangeable with the COF, just a flat list of links. Since outfits do store links rather than items, it should be that referencing the same item in multiple outfits will still work correctly - ie, if the item is updated, you will see the effects of the update in all outfits that use the item. However, this does not give you a grouping mechanism, so if you want to include the same half dozen items in a bunch of outfits you would have to add the item to each outfit individually, and ditto if you wanted to get rid of them. So the desire to keep items in groups makes sense, but it isn't the way things work currently; I'll make sure we track the request for possible future work.

I'm hoping we can get the other type of nesting - outfits inside folders - working sooner, as it should be a simpler code change.

Whirly Fizzle commented at 2015-11-23T22:47:56Z

This is fixed on http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/3.8.7.308081, at least for my repro steps above.
The appearance panel no longer hangs on "changing outfits...".
(https://bitbucket.org/lindenlab/viewer-bear/commits/133a540bfb0ee4ddad4affe2227450f7f6babb47)