This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
[BUG-8776] Favorite landmarks randomly reorder between sessions or when adding or removing a landmark from favorites. #16359
Labels
Steps to Reproduce
Add some landmarks to your favorite bar and rename them One, Two, Three, Four etc so it is easy to see if they change order - See Fig 1
The order of the favorite landmarks in the favorite bar will match the order of the landmarks in the favorite folder of inventory.
Add a new landmark to favorites by either dragging the landmark from the Landmarks inventory folder into its desired place in the favorite bar or by dragging a landmark from the Landmarks inventory folder into its desired place in the My Favorites inventory folder - see Fig 2
In Fig 2 I dragged a landmark from my Landmark folder to the favorite bar between favorite Eight and Nine.
Observe that my new landmark was not added between Eight and Nine - it added to the last place of my favorites.
Also observe that the order of my other landmarks has changed - One to Ten are correct but after that the order has changed to Twelve Fifteen Thirteen Fourteen Eleven.
Relog and observe if the order of the favorite landmarks has changed again.
Add and remove favorite landmarks and observe when the order changes.
When relogging, at the login screen, check the favorite landmarks in the "My Favorite Places" dropdown to see if the order has changed and whether all favorite landmarks display.
Observed Behaviour
At the login screen, the favorite landmarks in the "My Favorite Places" dropdown will often be missing one of the favorites.
For example, see Fig 3 - I relaunched the viewer after I had added the new landmark to favorites as shown in Fig 2
Observe that the COCO favorite shown in Fig 2 does not display in the My Favorite Places dropdown
Whenever a new landmark is added to the favorite bar, there is a high chance that the order of your favorites will change.
This reordering happens as soon as the new landmark is added.
This does not reproduce every time.
When a landmark is removed from favorites, there is a high chance that the order of your favorites will change.
Sometimes after relogging, the favorite landmark order has changed again.
I can't find a pattern to this, it just seems random when and how the favorite landmarks reorder.
Expected Behaviour
Favorite landmarks should not randomly reorder when relogging or when adding or removing a favorite landmark.
Favorite landmarks should all display under the "My Favorite Places" dropdown at the login screen.
Other Information
I think this started with https://bitbucket.org/lindenlab/viewer-release/commits/0ba119af3ac42d2242e4343f06d69ef96879db5c
This was the fix for BUG-5837
Also note that just to be sure I didnt have old favorite landmarks which were tainted by the BUG-5837 bug, I deleted all my favorite landmarks and recrested new ones and this problem still reproduced.
Attachments
Original Jira Fields
The text was updated successfully, but these errors were encountered: