Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-5928] [Group Bans] When banning an avatar who is already a group member using the "Ban Residents" tab, you do not receive the "You have ejected..." message. #13834

Open
sl-service-account opened this issue May 2, 2014 · 1 comment
Open

[BUG-5928] [Group Bans] When banning an avatar who is already a group member using the "Ban Residents" tab, you do not receive the "You have ejected..." message. #13834

sl-service-account opened this issue May 2, 2014 · 1 comment
Labels
project:BUG

Comments

@sl-service-account
Copy link

  • Viewer Build: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/baker_viewer-voorhees-groupban/rev/289672/index.html

  • Region: secondlife://Aditi/secondlife/Morris/202/203/34
    DRTSIM-234 14.04.23.289493

    Steps To Reproduce

  • Login Avatar A and Avatar B

  • Avatar A and Avatar B should both be members of Group C

  • Avatar A should have banning ability in group C

  • Avatar A go to Group C profile -> Roles & Members -> BANNED RESIDENTS -> Click Ban Resident(s) button

  • Select Avatar B in the avatar picker -> Ban residents

    Observed Behaviour

  • Avatar A receives no notification that they have ejected Avatar B from Group D. It appears that nothing happened.

  • Avatar B receives an IM from Avatar A saying "You have been ejected from "Group C" by Avatar A.

  • Avatar B is correct added to the Ban list for Group C.

    Expected Behaviour

    Avatar A should receive a notification saying "You ejected Avatar B from group Group C"

    Other Information

  • Other group owners correctly receive the IM from Avatar A saying "Avatar B has been ejected from 'Group C' by Avatar A.

  • If Avatar A bans group member Avatar B from Roles & Members -> Members -> Ban Member, Avatar A correctly receives the notification that Avatar B was ejected from the group.

Original Jira Fields
Field Value
Issue BUG-5928
Summary [Group Bans] When banning an avatar who is already a group member using the "Ban Residents" tab, you do not receive the "You have ejected..." message.
Type Bug
Priority Unset
Status Accepted
Resolution Accepted
Reporter Whirly Fizzle (whirly.fizzle)
Created at 2014-05-02T00:53:12Z
Updated at 2014-05-07T00:34:18Z 
{
  'Business Unit': ['Platform'],
  'Date of First Response': '2014-05-06T19:34:18.636-0500',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': '.',
  'What were you doing when it happened?': 'Filling in...',
  'What were you expecting to happen instead?': '.',
  'Where': 'DRTSIM-234 14.04.23.289493',
}
@sl-service-account
Copy link
Author

Maestro Linden commented at 2014-05-07T00:34:19Z

Hi Whirly, this change was actually by design - we removed that notification in this case. The "You have ejected..." message is actually bogus - it just confirms that you attempted to eject somebody, and wasn't a confirmation that ejection succeeded. As a result, you see the "You have ejected..." message in various cases where ejection actually failed (when the target became a group owner prior to the ejection attempt, when the target is not actually in the group, when you lost ejection permission, etc.).

Despite its removal in the case you describe, the "You have ejected..." message still exists in a different code path, leaving these bugs open:

  • MAINT-3341 “Misleading notification sent when group ejection fails due to permissions”
    • In this case, Avatar A lost his ability to eject Avatar B since Avatar A last opened the group floater. When Avatar A attempts to eject, there is a "You have ejected Avatar B" message, even though Avatar B is still in the group.
  • MAINT-3420 “Misleading notification to the second group owner who tries to double ban a member”
    • In this case, Avatar A successfully bans Avatar B from the group via the 'Members' -> 'Ban Member(s)' path, and receives the "You have ejected..." message. But afterwards, Avatar C, who can also ban users but did not refresh his group info floater recently, attempts to ban Avatar B through the same UI path. Avatar C receives an erroneous "You have ejected..." message, and
      receives the following message: "Unable to eject member 'Avatar B' from the group 'Group C'. Ejectee is not in the group."
      We should get rid of the other "You have ejected..." message to fix these bugs, and possibly add a new message which triggers after an ejection was confirmed to be successful.

Regarding the lack of feedback about a new ban being successful, there's another internal issue, MAINT-3386, that the ban list should be refreshed in the viewer following a ban via the 'Banned Residents' tab, which should provide the necessary feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
project:BUG
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sl-service-account