Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-5335] Certain dae files that used to display skin weights successfully now crash when ticking skin weights in model preview on ALL viewers #13334

Open
sl-service-account opened this issue Mar 9, 2014 · 5 comments

Comments

@sl-service-account
Copy link

sl-service-account commented Mar 9, 2014

This is a very strange issue and just does not make sense.
Certain rigged dae files that have in the past allowed display of skin weights in the upload preview and uploaded without problems are now crashing all viewers with mesh upload ability, on all regions when skin weights is ticked. Even older viewer builds from over a year ago are crashing.

Reproduced by multiple people on multiple viewers on different regions.

Steps to Reproduce.

  • Download the attached crash.dae to computer.

  • Go to Build -> Upload -> Model -> Choose crash.dae -> Open

  • In model preview floater, tick "Skin Weights"
    http://i.imgur.com/6wfWUWK.png

    Observed Behaviour

  • Viewer crashes to desktop.

  • Crash reports sent in from avatar Kippy Adored.

  • Logs attached - Kippy_logs.zip

    Callstack:

    Operating system: Windows NT
                      6.0.6002 Service Pack 2
    CPU: x86
         GenuineIntel family 6 model 23 stepping 10
         4 CPUs
    
    Crash reason:  EXCEPTION_ACCESS_VIOLATION_READ
    Crash address: 0x86f4477
    
    Thread 0 (crashed)
     0  SecondLifeViewer.exe!std::char_traits<char>::compare(char const *,char const *,unsigned int) [iosfwd : 486 + 0x12]
    
     1  SecondLifeViewer.exe!std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,LLImportMaterial,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,LLImportMaterial> >,0> >::_Lbound(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &) [xtree : 1746 + 0x2c]
    
     2  SecondLifeViewer.exe!std::map<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,LLImportMaterial,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,LLImportMaterial> > >::operator[](std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &) [map : 211 + 0x7]
    
     3  SecondLifeViewer.exe!LLModelPreview::render() [llfloatermodelpreview.cpp : 5570 + 0xb]
    
     4  SecondLifeViewer.exe!boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::signal2_impl<bool,LLControlVariable *,LLSD const &,boost_boolean_combiner,int,std::less<int>,boost::function<bool >,boost::function<bool >,boost::signals2::mutex>::slot_invoker,std::_List_iterator<std::_List_val<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group,boost::optional<int> >,boost::signals2::slot2<bool,LLControlVariable *,LLSD const &,boost::function<bool > >,boost::signals2::mutex> >,std::allocator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group,boost::optional<int> >,boost::signals2::slot2<bool,LLControlVariable *,LLSD const &,boost::function<bool > >,boost::signals2::mutex> > > > >,boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group,boost::optional<int> >,boost::signals2::slot2<bool,LLControlVariable *,LLSD const &,boost::function<bool > >,boost::signals2::mutex> >::lock_next_callable() [slot_call_iterator.hpp : 136 + 0x17]
    
     5  SecondLifeViewer.exe!LLViewerDynamicTexture::updateAllInstances() [lldynamictexture.cpp : 245 + 0xa]
    
     6  SecondLifeViewer.exe!display(int,float,int,int) [llviewerdisplay.cpp : 588 + 0x4]
    
     7  SecondLifeViewer.exe!LLAppViewer::mainLoop() [llappviewer.cpp : 1432 + 0x20]
    
     8  SecondLifeViewer.exe!WinMain [llappviewerwin32.cpp : 297 + 0x8]
    
     9  SecondLifeViewer.exe!__tmainCRTStartup [crtexe.c : 547 + 0x1b]
    
    10  kernel32.dll + 0x4d2e8
    
    11  ntdll.dll + 0x41602
    
    12  ntdll.dll + 0x415d5

    Expected behaviour

    No crash.

    Other Information

    Note that if skin weights is ticked in the upload options tab, the dae will upload successfully.
    It is only ticking skin weights in the preview options that crash the viewer.

    This one has me scratching my head....

Attachments

Original Jira Fields
Field Value
Issue BUG-5335
Summary Certain dae files that used to display skin weights successfully now crash when ticking skin weights in model preview on ALL viewers
Type Bug
Priority Unset
Status Accepted
Resolution Accepted
Reporter Whirly Fizzle (whirly.fizzle)
Created at 2014-03-09T14:42:46Z
Updated at 2015-06-20T02:36:00Z
{
  'Business Unit': ['Platform'],
  'Date of First Response': '2015-02-17T17:27:44.847-0600',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': '.',
  'What were you doing when it happened?': 'Filling in.....',
  'What were you expecting to happen instead?': '.',
  'Where': 'Anywhere, Any viewer.',
}
@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2014-03-09T18:50:28Z

Attaching another dae which crashes the viewer when ticking skin weight preview - billys_dog7.dae

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2014-03-09T19:12:33Z

I think this crash is only happening for rigged meshes with more then one material.

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2015-02-04T20:39:04Z

Crash still reproduces on Second Life 3.7.25 (298441) Jan 22 2015 14:56:32 (Second Life Project Importer)

@sl-service-account
Copy link
Author

Nicky Dasmijn commented at 2015-02-17T23:27:45Z

Attaching patch I made for Firestorm. Made against viewer-release

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2015-06-20T02:36:01Z

This is fixed on the MAINT-RC: http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/3.7.31.302685
MAINT-3818 Certain dae files that used to display skin weights successfully now crash when ticking skin weights in model preview on ALL viewers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant