Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-37637] DebugAvatarAppearanceMessage incorrectly reports all avatars received COF version as -1 #11975

Open
sl-service-account opened this issue Aug 12, 2016 · 2 comments

Comments

@sl-service-account
Copy link

Steps to Reproduce

  • Set DebugAvatarAppearanceMessage to TRUE.

  • Observe the floating text above other avatars heads.

  • Observe the "cof rcv:" value shown in the floating text for all avatars apart from yourself.

    Observed Behaviour

  • For all avatars apart from yourself, the received COF version will show as cof rcv: -1.

  • Example:
    http://image.prntscr.com/image/2ee281aa09ee4eabb40727a8fbe29da4.png

    Expected Behaviour

  • You should be able to see the correct received cof version for other avatars when DebugAvatarAppearanceMessage is enabled.

  • This broke fairly recently, somewhere in the later coroutine updates.

  • To see expected behaviour, you can use this early coroutine build where the bug does not reproduce: http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/4.0.3.312816

  • Observe on this build you correctly see other avatars received cof version.

  • Expected behaviour:
    http://image.prntscr.com/image/ac8ef1aa6b7e49488d6859560d077db8.png

    Other Information

    DebugAvatarAppearanceMessage is very useful for troubleshooting appearance problems & it's important to be able to view other avatars received cof version.
    Previously, on viewers without this bug, when an avatars received cof version remained stuck on -1, it was symptom of either multiple COF folders in their inventory (SUN-99) or their cof was corrupted in some other way.
    Probably only developers & support cares that this is no longer working :)

Original Jira Fields
Field Value
Issue BUG-37637
Summary DebugAvatarAppearanceMessage incorrectly reports all avatars received COF version as -1
Type Bug
Priority Unset
Status Accepted
Resolution Accepted
Reporter Whirly Fizzle (whirly.fizzle)
Created at 2016-08-12T04:53:38Z
Updated at 2016-08-12T22:45:15Z
{
  'Business Unit': ['Platform'],
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'Filling in...',
  'What were you doing when it happened?': '....',
  'What were you expecting to happen instead?': '....',
}
@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2016-08-12T08:42:16Z

From [~ansariel.hiller]

Most likely because

if (isSelf())
{
// Note:
// locally the COF is maintained via LLInventoryModel::accountForUpdate
// which is called from various places.  This should match the simhost's 
// idea of what the COF version is.  AIS however maintains its own version
// of the COF that should be considered canonical. 
mLastUpdateReceivedCOFVersion = thisAppearanceVersion;
}

of the isSelf() condition in llvoavatar.cpp

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2016-08-12T22:45:16Z

Fix from [~ansariel.hiller]: http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/2bb889c3d7a0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant