Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-37598] Server release notes in Help -> About Second Life never fetch on any region. #11953

Open
sl-service-account opened this issue Aug 3, 2016 · 1 comment

Comments

@sl-service-account
Copy link

sl-service-account commented Aug 3, 2016

Steps to Reproduce

  • Login to any region - main channel or an RC region.

  • Go to Help -> About Second Life

  • Observe if the server release notes fetch.

  • Close Help -> About Window & reopen it.

    Observed Behaviour

  • When you first open Help -> About Second Life in the session, the server release notes URL stays stuck on "Retrieving..."

  • See Fig 1.

  • After closing & reopening the Help -> About floater, you will always see "Error fetching server release notes URL."

  • See Fig 2.

  • The server release notes URL has not been loading for a good while now on any region.

  • I think this problem may only affect viewers using Coroutines.

  • Bug does not reproduce on the Obsolete Platforms viewer Second Life 3.7.28 (300847) Apr 13 2015 15:22:33 (Obsolete) or on Firestorm 4.7.7 release (which does not have coroutines merged in).
    Bug does however reproduce on Firestorm on builds after the coroutines merge.

  • Fig 3 shows the server release notes URL loading as expected on the Obsolete Platforms viewer.

  • Logs show:

    2016-08-03T04:22:30Z INFO: LLSDXMLParser::Impl::parse: LLSDXMLParser::Impl::parse: XML_STATUS_ERROR parsing:		<div id="contentSub"><span class="subpages">&lt; <a href="/wiki/Release_Notes" title="Release Notes">Release Notes</a>&lrm; | <a href="/wiki/Release_Notes/Second_Life_RC_BlueSteel" title="Release Notes/Second Life RC BlueSteel">Second Life RC BlueSteel</a></span></div>

    Expected Behaviour

    Server release notes URL should fetch.

Attachments

Original Jira Fields
Field Value
Issue BUG-37598
Summary Server release notes in Help -> About Second Life never fetch on any region.
Type Bug
Priority Unset
Status Accepted
Resolution Accepted
Reporter Whirly Fizzle (whirly.fizzle)
Created at 2016-08-03T04:27:52Z
Updated at 2016-08-06T13:23:19Z
{
  'Business Unit': ['Platform'],
  'Date of First Response': '2016-08-06T08:23:19.727-0500',
  'ReOpened Count': 0.0,
  'Regression?': ['Issue is a Regression'],
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'Filling in...',
  'What were you doing when it happened?': '...',
  'What were you expecting to happen instead?': '...',
}
@sl-service-account
Copy link
Author

Ansariel Hiller commented at 2016-08-06T13:23:20Z

This is broken in double way:

  1. The "About" window is never going to be updated at all. This is needed at the end of the LLFloaterAbout::handleServerReleaseNotes method
	LLFloaterAbout* floater_about = LLFloaterReg::findTypedInstance<LLFloaterAbout>("sl_about");
	if (floater_about)
	{
		floater_about->setSupportText(location);
	}
  1. Even with the first issue fixed, the release notes won't be shown as link in the floater because the release notes URL is sent in the HTTP header "location" attribute. Since the request for the release notes is routed via the HttpCoroutineAdapter::trivialGetCoro method which has the "follow redirect" option set, the viewer will receive the release notes with the "location" attribute and immediately start a redirected request at the received URL. For this to work, setFollowRedirects(false) needs to be called for the HTTP coroutine adapter before issuing the actual request.

Full fix can be found at http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/08ade708f102

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant