You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.
Login to any region - main channel or an RC region.
Go to Help -> About Second Life
Observe if the server release notes fetch.
Close Help -> About Window & reopen it.
Observed Behaviour
When you first open Help -> About Second Life in the session, the server release notes URL stays stuck on "Retrieving..."
See Fig 1.
After closing & reopening the Help -> About floater, you will always see "Error fetching server release notes URL."
See Fig 2.
The server release notes URL has not been loading for a good while now on any region.
I think this problem may only affect viewers using Coroutines.
Bug does not reproduce on the Obsolete Platforms viewer Second Life 3.7.28 (300847) Apr 13 2015 15:22:33 (Obsolete) or on Firestorm 4.7.7 release (which does not have coroutines merged in).
Bug does however reproduce on Firestorm on builds after the coroutines merge.
Fig 3 shows the server release notes URL loading as expected on the Obsolete Platforms viewer.
Server release notes in Help -> About Second Life never fetch on any region.
Type
Bug
Priority
Unset
Status
Accepted
Resolution
Accepted
Reporter
Whirly Fizzle (whirly.fizzle)
Created at
2016-08-03T04:27:52Z
Updated at
2016-08-06T13:23:19Z
{
'Business Unit': ['Platform'],
'Date of First Response': '2016-08-06T08:23:19.727-0500',
'ReOpened Count': 0.0,
'Regression?': ['Issue is a Regression'],
'Severity': 'Unset',
'System': 'SL Viewer',
'Target Viewer Version': 'viewer-development',
'What just happened?': 'Filling in...',
'What were you doing when it happened?': '...',
'What were you expecting to happen instead?': '...',
}
The text was updated successfully, but these errors were encountered:
The "About" window is never going to be updated at all. This is needed at the end of the LLFloaterAbout::handleServerReleaseNotes method
LLFloaterAbout* floater_about = LLFloaterReg::findTypedInstance<LLFloaterAbout>("sl_about");
if (floater_about)
{
floater_about->setSupportText(location);
}
Even with the first issue fixed, the release notes won't be shown as link in the floater because the release notes URL is sent in the HTTP header "location" attribute. Since the request for the release notes is routed via the HttpCoroutineAdapter::trivialGetCoro method which has the "follow redirect" option set, the viewer will receive the release notes with the "location" attribute and immediately start a redirected request at the received URL. For this to work, setFollowRedirects(false) needs to be called for the HTTP coroutine adapter before issuing the actual request.
Steps to Reproduce
Login to any region - main channel or an RC region.
Go to Help -> About Second Life
Observe if the server release notes fetch.
Close Help -> About Window & reopen it.
Observed Behaviour
When you first open Help -> About Second Life in the session, the server release notes URL stays stuck on "Retrieving..."
See Fig 1.
After closing & reopening the Help -> About floater, you will always see "Error fetching server release notes URL."
See Fig 2.
The server release notes URL has not been loading for a good while now on any region.
I think this problem may only affect viewers using Coroutines.
Bug does not reproduce on the Obsolete Platforms viewer Second Life 3.7.28 (300847) Apr 13 2015 15:22:33 (Obsolete) or on Firestorm 4.7.7 release (which does not have coroutines merged in).
Bug does however reproduce on Firestorm on builds after the coroutines merge.
Fig 3 shows the server release notes URL loading as expected on the Obsolete Platforms viewer.
Logs show:
Expected Behaviour
Server release notes URL should fetch.
Attachments
Original Jira Fields
The text was updated successfully, but these errors were encountered: