You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.
In the current release viewer, since maint J+K as best I can tell, changing the target triangles of a LOD does not refresh the floater, leaving a blank preview.
deselecting and reselecting generate is a workaround.
the traingle count for the affected LOD should update and the preview should show the new generated LOD
Other information
the simplest fix is to force a floatermodelpreview refresh on the callback for the spinner controls (onLODParamCommit). I've not yet confirmed if there were other side-effects of the change that caused this bug.
Below is the function and the one line fix, if it is useful but given that you are likely to release the meshoptimiser changes before the next Maint this is probably not worthwhile.
{
'Build Id': 'unset',
'Business Unit': ['Platform'],
'Date of First Response': '2022-03-28T12:40:00.664-0500',
"Is there anything you'd like to add?": "the simplest fix is to force a floatermodelpreview refresh on the callback for the spinner controls (onLODParamCommit). I've not yet confirmed if there were other side-effects of the change that caused this bug.\r\n\r\nBelow is the function and the one line fix, if it is useful but given that you are likely to release the meshoptimiser changes before the next Maint this is probably not worthwhile.\r\n\r\nvoid LLModelPreview::onLODParamCommit(S32 lod, bool enforce_tri_limit)\r\n{\r\n if (!mLODFrozen)\r\n {\r\n genLODs(lod, 3, enforce_tri_limit);\r\n mFMP->refresh(); // <FS:Beq/> Fix b0rken upload floater refresh\r\n refresh();\r\n }\r\n}\r\n\r\n",
'ReOpened Count': 0.0,
'Severity': 'Unset',
'System': 'SL Viewer',
'Target Viewer Version': 'viewer-development',
'What just happened?': 'In the current release viewer, since maint J+K as best I can tell, changing the target triangles of a LOD does not refresh the floater, leaving a blank preview.\r\ndeselecting and reselecting generate is a workaround.\r\n\r\nThis shows the issue and the "workaround"\r\nhttps://gyazo.com/12c9e496e4af72d3d9eb50c7680cba92',
'What were you doing when it happened?': 'uploading mesh',
'What were you expecting to happen instead?': 'the traingle count for the affected LOD should update and the preview should show the new generated LOD',
'Where': 'anywhere',
}
The text was updated successfully, but these errors were encountered:
What just happened?
In the current release viewer, since maint J+K as best I can tell, changing the target triangles of a LOD does not refresh the floater, leaving a blank preview.
deselecting and reselecting generate is a workaround.
This shows the issue and the "workaround"
https://gyazo.com/12c9e496e4af72d3d9eb50c7680cba92
What were you doing when it happened?
uploading mesh
What were you expecting to happen instead?
the traingle count for the affected LOD should update and the preview should show the new generated LOD
Other information
the simplest fix is to force a floatermodelpreview refresh on the callback for the spinner controls (onLODParamCommit). I've not yet confirmed if there were other side-effects of the change that caused this bug.
Below is the function and the one line fix, if it is useful but given that you are likely to release the meshoptimiser changes before the next Maint this is probably not worthwhile.
void LLModelPreview::onLODParamCommit(S32 lod, bool enforce_tri_limit)
{
if (!mLODFrozen)
{
genLODs(lod, 3, enforce_tri_limit);
mFMP->refresh(); // FS:Beq/ Fix b0rken upload floater refresh
refresh();
}
}
Original Jira Fields
The text was updated successfully, but these errors were encountered: