Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-230697] Simple cache viewer: Do not crash during cache purge #8310

Closed
sl-service-account opened this issue May 6, 2021 · 5 comments
Closed

[BUG-230697] Simple cache viewer: Do not crash during cache purge #8310

sl-service-account opened this issue May 6, 2021 · 5 comments
Labels
project:BUG

Comments

@sl-service-account
Copy link

The viewer should not crash due to an exception during cache purge/clean, if for some reason the removal of a file fails:

https://vcs.firestormviewer.org/phoenix-firestorm/changeset/14b1cf185200ff34805fe075a6211055f711eccd

Original Jira Fields
Field Value
Issue BUG-230697
Summary Simple cache viewer: Do not crash during cache purge
Type Bug
Priority Unset
Status Closed
Resolution Triaged
Reporter Ansariel Hiller (ansariel.hiller)
Created at 2021-05-06T10:23:32Z
Updated at 2022-01-13T00:56:11Z 
{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2021-05-06T12:33:05.835-0500',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'The viewer should not crash due to an exception during cache purge/clean, if for some reason the removal of a file fails:\r\n\r\nhttps://vcs.firestormviewer.org/phoenix-firestorm/changeset/14b1cf185200ff34805fe075a6211055f711eccd',
  'What were you doing when it happened?': '-',
  'What were you expecting to happen instead?': '-',
}
@sl-service-account
Copy link
Author

Dan Linden commented at 2021-05-06T17:33:06Z

Thank you for the report, Ansariel!

@sl-service-account
Copy link
Author

Callum Linden commented at 2021-05-11T18:09:17Z

Thank you for the fix (surprised boost throws an exception at all and added a return code stops it...) - Vir asked if you could please submit a PR vs a pointer to a diff so it can be pulled in cleanly.

@sl-service-account
Copy link
Author

Ansariel Hiller commented at 2021-05-11T18:29:42Z

It has always been the case and still is in the most current boost version, see https://www.boost.org/doc/libs/1_76_0/libs/filesystem/doc/reference.html#Error-reporting

That applies to the remove() function as well since it has an overloaded version with error code.

PR: https://bitbucket.org/lindenlab/viewer/pull-requests/567/bug-230697-do-not-crash-viewer-during

@sl-service-account
Copy link
Author

Callum Linden commented at 2021-05-11T18:49:50Z

Understood and thank you for the quick reply.

@sl-service-account
Copy link
Author

Jeffbot Linden commented at 2022-01-13T00:56:12Z

Mentioned in build 567457 for DRTVWR-535 (Enhanced Map Tiles Viewer)

BUG-230697: Do not crash viewer during cache cleanup

Approved-by: Callum Linden

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
project:BUG
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sl-service-account