Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-229201] [EEP] Alpha Masked faces do not appear in water reflections in ALM #7127

Closed
sl-service-account opened this issue Aug 9, 2020 · 2 comments

Comments

@sl-service-account
Copy link

sl-service-account commented Aug 9, 2020

What just happened?

All reflections of items or faces being alpha and set to alpha mode "Alpha Masking" are not showing up in reflections with ALM enabled.

Steps to reproduce:

  1. Enable ALM and make sure its working.

  2. Go near any water surface while wearing any alpha masked item, with Mask cutoff > 0, be it rigged or not.

  3. Observe the item/face missing in the water reflections. See images.

    Other information

    Happens since EEP.

    It is fixed in Love Me Render it seems. Not sure exactly which commit fixed it.

Attachments

Original Jira Fields
Field Value
Issue BUG-229201
Summary [EEP] Alpha Masked faces do not appear in water reflections in ALM
Type Bug
Priority Unset
Status Closed
Resolution Triaged
Labels whirly-eep
Reporter NiranV Dean (niranv.dean)
Created at 2020-08-09T10:22:45Z
Updated at 2020-09-28T17:12:09Z
{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2020-08-10T14:25:37.207-0500',
  "Is there anything you'd like to add?": 'Happens since EEP.',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'All reflections of items or faces being alpha and set to alpha mode "Alpha Masking" are not showing up in reflections with ALM enabled.',
  'What were you doing when it happened?': 'Looking at water',
  'What were you expecting to happen instead?': 'Show reflections',
}
@sl-service-account
Copy link
Author

NiranV Dean commented at 2020-08-10T09:10:35Z

I found out what the issue is.

The class 1 shader lightAlphaMask.glsl does have a tiny little bug.

In void default_lighting() color is multiplied by vertex_color BEFORE discarding rather than after discarding. image-2020-08-10-11-07-09-511.png

The fix is as simple as moving it down.

image-2020-08-10-11-07-52-832.png

@sl-service-account
Copy link
Author

Dan Linden commented at 2020-08-10T19:25:37Z

Thank you for the report, NiranV.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant