Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-229122] [EEP] Glow should be directly behind the sun or moon when it is near the horizon. #7061

Closed
3 tasks
sl-service-account opened this issue Jul 22, 2020 · 3 comments

Comments

@sl-service-account
Copy link

sl-service-account commented Jul 22, 2020

Repro

  1. Copy the "[NB] P-Haze" day cycle from the Library to your Inventory and edit it.
  2. Select the second keyframe.
  3. Look at the moon.

Observed: The pink glow if offset from the moon. See "glow offset 6.4.4.543157.png"

Expected: The glow should be directly behind the moon.


Original report:

What just happened?

Use the [NB] P-Haze preset as a personal lighting environment.

Adjusting the sun position controller affects the moon glow. ( This kind of makes sense? Theoretically? ) Except the result is somewhat nonsensical.

When the sun is below the horizon the moon gets a halo around it ~ but not well centered on the moondisc. It's kind of an off-centered halo/glow.
This halo blinks into existence when the sun drops below the horizon line and instantly vanishes. I'm assuming this is "intended" in some manner or another ~ when the sun is below the horizon line ~ it suddenly is "reflecting" light off the moon? This should happen regardless of whether the sun is below the horizon line though.

I don't even know what is "working as intended" at this point ~ but I don't think this is it.

https://gyazo.com/53bebec6267858697c7aeab6f1302304

What were you doing when it happened?

Trying to reproduce a completely different moon bug.

What were you expecting to happen instead?

I was expecting any sort of moonglow halo to be centered on the moon object ~ or ... something? I wasn't expecting it to be tied to Sun Position~ though I have a hunch that the halo blinking on and off is tied to https://jira.secondlife.com/browse/BUG-229033

Other information

The off-centered light effect seems to be similar to this bug report as well : https://jira.secondlife.com/browse/BUG-229013

Attachments

Links

Related

Original Jira Fields
Field Value
Issue BUG-229122
Summary [EEP] Glow should be directly behind the sun or moon when it is near the horizon.
Type Bug
Priority Unset
Status Closed
Resolution Triaged
Labels whirly-eep
Created at 2020-07-22T01:45:41Z
Updated at 2021-06-07T17:42:54Z
{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2020-07-23T16:42:40.469-0500',
  "Is there anything you'd like to add?": 'The off-centered light effect seems to be similar to this bug report as well : https://jira.secondlife.com/browse/BUG-229013 ',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'Use the [NB] P-Haze preset as a personal lighting environment.\r\n\r\nAdjusting the sun position controller affects the moon glow.  ( This kind of makes sense? Theoretically? ) Except the result is somewhat nonsensical.\r\n\r\nWhen the sun is below the horizon the moon gets a halo around it ~ but not well centered on the moondisc.  It\'s kind of an off-centered halo/glow.\r\nThis halo blinks into existence when the sun drops below the horizon line and instantly vanishes.  I\'m assuming this is "intended" in some manner or another ~  when the sun is below the horizon line ~ it suddenly is "reflecting" light off the moon?  This should happen regardless of whether the sun is below the horizon line though.\r\n\r\nI don\'t even know what is "working as intended" at this point ~ but I don\'t think this is it.\r\n\r\nhttps://gyazo.com/53bebec6267858697c7aeab6f1302304\r\n',
  'What were you doing when it happened?': 'Trying to reproduce a completely different moon bug.',
  'What were you expecting to happen instead?': "I was expecting any sort of moonglow halo to be centered on the moon object ~ or ... something?  I wasn't expecting it to be tied to Sun Position~  though I have a hunch that the halo blinking on and off is tied to https://jira.secondlife.com/browse/BUG-229033",
}
@sl-service-account
Copy link
Author

Dan Linden commented at 2020-07-23T21:42:40Z

Thank you for the report, polysail!

It is expected that the sun will have the glow if both the sun and moon are visible.

@sl-service-account
Copy link
Author

polysail commented at 2020-07-23T23:56:48Z

Okay ~ but the sharp transition between the two is not ideal.  Why is there a limit to one glowing entity in the sky at a time?  That seems weird.  They should be glowing independently no?  The moon frequently appears in the sky at the same time that the sun does.

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2021-01-07T18:53:12Z

Fix is in LMR-5: Fix is in LMR 5: https://releasenotes.secondlife.com/viewer/6.4.12.553511.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant