Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-228838] Viewer changes have broken my entire outfit system #6827

Closed
5 tasks
sl-service-account opened this issue May 29, 2020 · 24 comments
Closed
5 tasks

Comments

@sl-service-account
Copy link

sl-service-account commented May 29, 2020

What just happened?

I just tried to paste an item link into one of my custom folders in My Outfits and received the error message "One or more items can't be used inside 'My Outfits.'"

What were you doing when it happened?

Editing my outfit setup.

What were you expecting to happen instead?

I was expecting to be able to use my custom-created outfit folders as I have for years.

Other information

I have a fully organized outfit system with outfits organized by avatar and outfit type. While my subfolders are not visible in Appearance, they allow me to have an organized "My Outfits" folder. In addition, I have subfolders for each outfit's HUDs and other items that I may want to use with the outfit, but that I do not want to load onto my screen or my avatar just because I put the outfit on. For instance, I may have several different jewelry/accessory variations that I use with a given outfit. I don't want those all to load onto my avatar and then have to remove them. With HUDs, I sometimes have those saved in the system outfit folder (such as numbers of appliers), but putting them additionally in another folder allows me to select that folder and remove all the HUDs at once, rather than right-click-detach over and over.

Please see the attached image for my organized outfit system.

Please reconsider this change. I have spent hundreds or thousands of hours setting up this system, which works without fault or side effect. If the change is not reverted, I will have to (once again) remove all my outfits from "My Outfits" and will be unable to use the "Save Outfits" feature. This will create extra work for me every time I want to create an outfit.

We have also had complaints about this in Firestorm support, from other users.

Attachments

Links

Related

Original Jira Fields
Field Value
Issue BUG-228838
Summary Viewer changes have broken my entire outfit system
Type Bug
Priority Unset
Status Closed
Resolution Cannot Reproduce
Reporter Anastasia Horngold (anastasia.horngold)
Created at 2020-05-29T19:28:59Z
Updated at 2021-07-19T18:16:14Z
{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2020-05-29T15:00:29.251-0500',
  "Is there anything you'd like to add?": 'I have a fully organized outfit system with outfits organized by avatar and outfit type. While my subfolders are not visible in Appearance, they allow me to have an organized "My Outfits" folder. In addition, I have subfolders for each outfit\'s HUDs and other items that I may want to use with the outfit, but that I do not want to load onto my screen or my avatar just because I put the outfit on. For instance, I may have several different jewelry/accessory variations that I use with a given outfit. I don\'t want those all to load onto my avatar and then have to remove them. With HUDs, I sometimes have those saved in the system outfit folder (such as numbers of appliers), but putting them additionally in another folder allows me to select that folder and remove all the HUDs at once, rather than right-click-detach over and over.\r\n\r\nPlease see the attached image for my organized outfit system.\r\n\r\nPlease reconsider this change. I have spent hundreds or thousands of hours setting up this system, which works without fault or side effect. If the change is not reverted, I will have to (once again) remove all my outfits from "My Outfits" and will be unable to use the "Save Outfits" feature. This will create extra work for me every time I want to create an outfit.\r\n\r\nWe have also had complaints about this in Firestorm support, from other users.',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'I just tried to paste an item link into one of my custom folders in My Outfits and received the error message "One or more items can\'t be used inside \'My Outfits.\'"',
  'What were you doing when it happened?': 'Editing my outfit setup.\r\n',
  'What were you expecting to happen instead?': 'I was expecting to be able to use my custom-created outfit folders as I have for years.',
}
@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2020-05-29T20:00:29Z

Possibly caused by: https://bitbucket.org/lindenlab/viewer/commits/1f1b51c7ce9f34978b1caa09a07b972ce07b027f

@sl-service-account
Copy link
Author

PatrickR Bleac commented at 2020-06-01T12:24:00Z

I'm using the same system and was very unpleasantly surprised by this downgrade. In my humble opinion a quick revert is in order.

@sl-service-account
Copy link
Author

CliftonDownes commented at 2020-06-02T11:25:36Z

I used to create a new folder in "outfits" - I can still do that. then I would copy my "current Outfit" into the new folder as links! That worked before, it doesn't work now Therefore something has changed i.e. broken!

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2020-06-02T18:06:43Z

REPRO

  • Left click on Outfits folder in inventory to highlight it.
  • Right click on Outfits folder - Create new folder.
  • Name this new folder TEST.
  • Copy any link from another saved outfits folder.
  • Attempt to paste this link into the TEST folder.
  • Observed: Error message One or more items can't be used inside 'My Outfits
  • Note that you CAN drag and drop links into the TEST folder though, so what is the point of blocking copy & paste?

@sl-service-account
Copy link
Author

Dan Linden commented at 2020-06-04T17:17:42Z

[~anastasia.horngold] There may be more than one way to trigger the error message and I want to make sure we are capturing your repro steps. Are you doing the exact steps that Whirly stated above? If not, would you list the exact steps or attach a video of what you are doing?

@sl-service-account
Copy link
Author

PatrickR Bleac commented at 2020-06-04T17:32:26Z, updated at 2020-06-04T17:32:38Z

I can confirm Whirly's scenario.  Drag&dropping a link from my normal folders also works.

Drag&dropping a link from "Current outfit" is blocked no matters where in my inventory I try to place it (no error message, just a red cursor). Using ctrl+c on a link in  "Current outfit" and then using ctrl+v on a normal folder copies the link as expected.

@sl-service-account
Copy link
Author

Anastasia Horngold commented at 2020-06-04T20:12:03Z, updated at 2020-06-04T21:12:22Z

Test 1 — Moving an outfit into a manually created subfolder.

Right click My Outfits > New Folder
Name the folder TEST CATEGORY
Right click myself > Edit Outfit > Save Outfit as TEST OUTFIT A
Drag TEST OUTFIT A into TEST CATEGORY
Note that this works. :)

Create a second new outfit, TEST OUTFIT B
Attempt to cut/paste this with Ctrl-X and Ctrl-V into TEST CATEGORY.
Note that this fails, with no error message. (There is no cut or copy option in the right click menu, either).

Summary: Works fine with drag/drop, fails with cut/paste, no error message.

(I think this is not a change; I have been using drag/drop because cut/paste doesn’t work. This often requires a very awkward and long drag/drop.)

Test 2 — Adding an item to a system outfit folder manually

Anywhere in inventory, create a new system shirt.
Name it TEST SHIRT
Drag TEST SHIRT onto the TEST OUTFIT A folder.
Note that this works.

Right click the original TEST SHIRT > Copy or Ctrl-C
Select the TEST OUTFIT A folder
Attempt to paste (Ctrl-V)
Note that this fails—Error message “One or more items can’t be used inside My Outfits.”
Also note that in this case, the destination was a system folder, not a manually created folder.

Summary: Previously, you could copy/paste a system outfit into a system folder manually with no trouble. (This would of course create a link). Now, you can drag/drop it, but you cannot copy/paste it. This is the same for attachments. 

Test 3 — Copying a link from Current Outfit into a system folder

Right click a link in Current Outfit
Notice that Copy is now greyed out. (This is a change)
Instead, do Ctrl-C (no error message) and then Ctrl-V onto TEST OUTFIT A (which is inside a manual subfolder).
Note that this fails with error message “One or more items can’t be used inside My Outfits.”

Now Ctrl-C the item in COF again, and Ctrl-V onto TEST OUTFIT B.
Note that this fails with no error message.

Attempt to drag a link from Current Outfit into either TEST OUTFIT A or B
Note that this fails for both.

Summary: You can no longer copy or drag a link from COF into a saved system outfit folder, whether or not it's inside a manual subfolder. This used to work.

Test 4 — Adding individual items to a manually created folder

Right click TEST CATEGORY > New Folder
Name this folder TEST OUTFIT A—ACCESSORIES
Drag an applier HUD or some other accessory in.
Note that this works.

Try to copy the item in using right-click-copy or Ctrl-V.
Note that this fails with error message “One or more items can’t be used inside My Outfits.”

Summary: You can drag an inventory item into a manually created folder, but not copy/paste.

@sl-service-account
Copy link
Author

Ansariel Hiller commented at 2020-06-08T19:46:30Z

Dan, the "problem" here is that apparently some users used the outfit system in an unintended way by "creating" outfits via the inventory window and simply adding new folders to it, instead of creating outfits via the appearance floater.

This became a problem with this change that now checks the folder type you are copying into. Since the users create folders of type FT_NONE (normal folders) instead of FT_OUTFIT (outfit folders), this will trigger the validation check failure.

Removing the check or modifying to allow folders of type FT_NONE to be used as outfit folders seem to be the wrong way. Instead, it should be possible to create actual outfit folders underneath the My Outfits folder instead of creating normal folders. This can be done like this.

@sl-service-account
Copy link
Author

Anastasia Horngold commented at 2020-06-08T22:37:44Z, updated at 2020-12-19T02:48:10Z

Just to clarify, I am creating outfits using the Appearance folder. I also edit/modify them using the Appearance window. It all works fine.

The problem is no longer being able to organize as I have been doing using manually created folders/subfolders.

@sl-service-account
Copy link
Author

Ansariel Hiller commented at 2020-06-09T06:02:34Z

Because "manually created" folders are not outfit folders from a technical point of view. They are of type FT_NONE instead of FT_OUTFIT. If you would have created outfit folders using the Appearance window or the new way of adding actual outfit folders underneath the My Outfits folder, it will work fine.

@sl-service-account
Copy link
Author

Anastasia Horngold commented at 2020-06-09T07:42:25Z

As long as they're nestable, that would be great.

@sl-service-account
Copy link
Author

Anastasia Horngold commented at 2020-12-14T20:50:33Z

Update: Outfit folders created by the system cannot be dragged into each other, so they cannot be nested.

@sl-service-account
Copy link
Author

Vir Linden commented at 2021-01-06T16:31:01Z, updated at 2021-01-06T16:33:48Z

Testing on the current default viewer, I can do the following:

  • Right click "My Outfits" and do "New Folder". This creates a non-outfit folder (type FT_NONE) for storing groups of outfits in.

  • Drag an existing outfit (type FT_OUTFIT) into that new folder

  • Right click the outfit and pick "Replace Current Outfit"

    Is this enough to allow you to manage outfits in groups?

    Note that each outfit folder should be a discrete appearance, so actual outfits shouldn't be draggable into each other.

@sl-service-account
Copy link
Author

Vir Linden commented at 2021-01-06T16:39:08Z

If you look at the image under "Nesting outfits example", you can see how this works. It's a little confusing keeping track of the different folder types, but you can see in the UI which is which - "My Outfits" and "vamp" are special folder types with custom icons. "Vamp" is an outfit, so it has the hanger icon. "AAA New Folder" is just used for grouping, and has no special type, so there's no icon.

@sl-service-account
Copy link
Author

Anastasia Horngold commented at 2021-01-06T17:47:57Z

That's a huge improvement. It at least allows the outfit folders to be grouped. Thank you!

It's missing one ability that I depend on, though, which is the ability to move a few of the links into an adjunct folder inside outfits. (I described this in the OP - see detail below.)

The only way to do something similar seems to be to save the entire outfit a second time, then delete the unwanted links. I suppose that's a workable workaround; it just seems like unnecessary trouble.


Detail of organization

I organize my outfits like this:

AAA grouping folder ("Short dresses - Spring - Casual")

---bbb1 grouping folder - Outfit 1 ("Lavender mini with silver machine gun")

   -----HUDS, appliers needed for outfit 1 (manually created folder)

   ----~~Actual system folder with "hanger" icon (contains outfit without all the HUDS or appliers)

-~~-bbb2 grouping folder - Outfit 2 ("Green polka dot mini with roller skates"

   -----HUDS

   -----system folder with main outfit

(repeat)

 

This avoids these ongoing problems:

  1. Having to remove a half-dozen HUDs (appliers) from screen every time you put on an outfit. Since the applier links are stored in a secondary folder, they aren't added when wearing the main outfit. But they are accessible if needed.

  2. Accidentally re-saving an outfit and losing track of its appliers. Repro:

  1. Wear an outfit that includes appliers (makeup, tattoos, hairbases, nail polish, stockings, underwear...)

  2. Reapply whatever appliers need to be redone

  3. Remove appliers

  4. Go about your SL, then make some change (change hair or shoes, perhaps).

  5. Resave outfit, forgetting that the appliers aren't worn.

  6. The following week/month, wear outfit again and have no way to find what the appliers were.

     

@sl-service-account
Copy link
Author

Ansariel Hiller commented at 2021-01-06T18:01:25Z, updated at 2021-01-06T19:24:04Z

@vir Linden, where is the option to manually create an actual outfit folder? I mean, something like https://bitbucket.org/Ansariel/viewer-outfit/commits/84983417607dfd7d643c76038a8fb87a87c83cc4 ... ;)

@sl-service-account
Copy link
Author

Vir Linden commented at 2021-01-07T14:13:47Z

Hey Ansariel, that does look useful. If you're happy submitting that as a contribution we can discuss adding it.

As far as I know the only way to make an outfit today is by doing Save/Save As in the appearance window. One advantage perhaps to this approach is that it does not allow you to create an incomplete outfit (ie, one missing required body parts). Trying to wear an incomplete outfit would leave the user clouded and confused.

@sl-service-account
Copy link
Author

Vir Linden commented at 2021-01-07T14:16:50Z

Anastasia, what issues are preventing you from using the HUD-management workflow you describe? Is it just the ability to create links in a non-outfit folder?

@sl-service-account
Copy link
Author

Ansariel Hiller commented at 2021-01-07T15:59:51Z, updated at 2021-01-07T16:04:38Z

Hi Vir! Regard that as contribution. LL has my CA, so feel free to use it. But as mentioned in other places, allowing outfits in subfolders will cause the outfits list in the appearance window not update properly, since it's only observing the My Outfits folder itself. That will need some additional work.

@sl-service-account
Copy link
Author

JIRAUSER335676 commented at 2021-01-16T14:40:35Z, updated at 2021-01-16T14:41:09Z

From my point of view, the failure of outfits in the Appearance window is immaterial - I never use it!  But the sudden inability to create folders inside the Outfits folder is a terrible reversion to what appears to have been a policy back in 2014-15, if my reading of this discussion https://community.secondlife.com/forums/topic/317290-why-can-i-no-longer-move-outfits-to-subfolders-in-the-my-outfits-folder/ is correct but which was presumably then wisely reversed - till now.  For the first time, I am unable to create subfolders, and it is a serious annoyance.  Please fix ASAP!

@sl-service-account
Copy link
Author

JIRAUSER336737 commented at 2021-04-10T07:51:48Z

I too, have run into this issue. It only seems to pertain to normal folders in the Outfits folder for me.

If it's an Outfit Folder, and not a normal folder, i can copy items into it.

But normal folders, i can not. This has caused me to recreate every outfit I have ever made into Outfit folders.

This is seriously broken and really should be fixed.

@sl-service-account
Copy link
Author

Vir Linden commented at 2021-04-12T12:55:53Z

harlequinn87, so you are trying to have a setup like 

My Outfits->Folder->items...

and can't copy items into the folder? When do you want to use a folder there, instead of using an outfit like:

My Outfits->Outfit->item links... instead?

@sl-service-account
Copy link
Author

Dan Linden commented at 2021-05-28T18:40:12Z

The Maintenance "Fernet" viewer at https://releasenotes.secondlife.com/viewer/6.4.19.559726.html has a fix for this issue.

How does it look?

@sl-service-account
Copy link
Author

Anastasia Horngold commented at 2021-05-28T21:03:16Z, updated at 2021-06-01T20:37:22Z

In "Fernet," this works:

  • Able to create new regular folders inside Outfits.

  • Able to add manual subfolders.

  • Able to drag system outfit folders inside different levels of manual folders.

    So to a great extent, this solves the issue as originally described, and is a big help. When trying to work inside My Outfits there are still a lot of blocks and oddities, though. 

    This doesn't work:

    Unable to copy/paste a link from a system outfit folder into a manual folder (such as a folder for items auxiliary to a system outfit). This can still be worked around in a couple of ways, so the restriction seems unneeded:

  • by dragging a link from a system outfit folder into the manual folder (which creates a copy rather than just moving the item)

  • by scrolling all the way up to the main Outfits folder, right click > create new outfit, then scrolling all the way down to find the New Outfit folder, then dragging it all the way to the desired manual folder (cumbersome)

    Unable to cut/paste or copy/paste a system outfit folder into a manual folder. Can only drag the folder. This can be very cumbersome in a long list. Attempting to cut/copy/paste has some odd results:

  • Scenario 1

  1. Select a system outfit folder that is in the top level in the My Outfits folder
  2. Ctrl-C.
  3. Go to a manual folder and ctrl-V
  4. Notice that a copy of the outfit appears under the main My Outfits folder but nothing is added to the manual folder. (no error message)
  • Scenario 2
  1. Select a system outfit folder that is in the top level in My Outfits folder
  2. Ctrl-X.
  3. Go to a manual folder and ctrl-V
  4. Notice that a copy of the outfit appears under the main My Outfits folder but nothing is added to the manual folder, and the original stays in place rather than disappearing. (no error message)
  • Scenario 3

  • Select a system outfit folder that is in a manual subfolder in My Outfits

  • Ctrl-C.

  • Go to another manual folder and ctrl-V

  • Notice that the outfit folder doesn't move (silent fail)**

  • Scenario 4

  1. Select a system outfit folder that is in a manual subfolder in My Outfits

  2. Ctrl-X.

  3. Go to a manual folder and ctrl-V

  4. Notice that a copy of the outfit appears under the top My Outfits level but nothing is added to the manual folder, and the original stays in place rather than disappearing. (no error message)

    Unable to copy/paste an item from regular inventory into a system outfit folder (error: "one or more items can't be used inside 'My Outfits').

  • This is relatively minor since the fix is to right click inside a system outfit folder and use "paste as link", but why not make the "paste as link" automatic when pasting anywhere inside My Outfits? 
  • Also, why is it necessary to open the system outfit folder and paste inside it? Normal functioning would be to paste onto the folder itself, just like in regular inventory.
  • Use case:
  1. Realize you want to add Accessory A to 15 specific outfits.

  2. Copy Accessory A from regular inventory

  3. In My Outfits, ctrl-click to select the 15 outfit folders. 

  4. Attempt to paste via Ctrl-V - fail with error "one or more items can't be used..."

  5. Proceed to open each folder manually and paste the item in one at a time.

     

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant