Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-228508] EEP - Asymmetric conversions of sun_angle and east_angle to/from legacy #6580

Closed
sl-service-account opened this issue Apr 16, 2020 · 1 comment
Closed

[BUG-228508] EEP - Asymmetric conversions of sun_angle and east_angle to/from legacy #6580

sl-service-account opened this issue Apr 16, 2020 · 1 comment
Labels
project:BUG

Comments

@sl-service-account
Copy link

sl-service-account commented Apr 16, 2020 •
edited by sl-issues-importer bot

What just happened?

The two attached old-style preset files fail the symmetrical conversion tests in llsettingsvo.cpp while creating a new sky by importing legacy presets (this code is ifdef'd off in the source but I've re-enabled it for testing it in a Kokua build, it also needs some minor changes before it'll compile).

File 1: foggy_sun 03

Note that sun_angle fails the test.

2020-04-16T16:10:01Z WARNING #SKY# newview/llsettingsvo.cpp(486) LLSettingsVOSky::buildFromLegacyPreset : Conversion to/from legacy does not match!\nOld: {'ambient':[r0.330000,r0.330000,r0.330000,r0.110000],'blue_density':[r0.145225,r0.399997,r0.800002,r1.000000],'blue_horizon':[r0.430702,r0.853947,r1.000000,r1.000000],'cloud_color':[r0.700000,r0.700000,r0.700000,r0.700000],'cloud_pos_density1':[r0.500000,r0.500000,r0.540000,r1.000000],'cloud_pos_density2':[r0.500000,r0.500000,r0.125000,r1.000000],'cloud_scale':[r0.300000,r0.000000,r0.000000,r1.000000],'cloud_scroll_rate':[r10.499400,r10.011000],'cloud_shadow':[r0.400000,r0.000000,r0.000000,r1.000000],'density_multiplier':[r0.000350,r0.000000,r0.000000,r1.000000],'distance_multiplier':[r4.000000,r0.000000,r0.000000,r1.000000],'east_angle':r0.000000,'enable_cloud_scroll':[1,1],'gamma':[r1.000000,r0.000000,r0.000000,r1.000000],'glow':[r3.800000,r0.001000,r-0.500000,r1.000000],'haze_density':[r4.000000,r0.000000,r0.000000,r1.000000],'haze_horizon':[r0.650000,r0.199156,r0.199156,r1.000000],'lightnorm':[r0.000000,r1.000000,r-0.000000,r0.000000],'max_y':[r600.000000,r0.000000,r0.000000,r1.000000],'preset_num':i18,'star_brightness':r0.000000,'sun_angle':r1.884954,'sunlight_color':[r0.540000,r0.540000,r0.540000,r0.180000]}new:

{'ambient':[r0.330000,r0.330000,r0.330000,r1.000000],'blue_density':[r0.145225,r0.399997,r0.800002,r1.000000],'blue_horizon':[r0.430702,r0.853947,r1.000000,r1.000000],'cloud_color':[r0.700000,r0.700000,r0.700000,r1.000000],'cloud_pos_density1':[r0.500000,r0.500000,r0.540000,r1.000000],'cloud_pos_density2':[r0.500000,r0.500000,r0.125000,r1.000000],'cloud_scale':[r0.300000,r0.000000,r0.000000,r1.000000],'cloud_scroll_rate':[r0.499400,r0.011000],'cloud_shadow':[r0.400000,r0.000000,r0.000000,r1.000000],'density_multiplier':[r0.000350,r0.000000,r0.000000,r1.000000],'distance_multiplier':[r4.000000,r0.000000,r0.000000,r1.000000],'east_angle':r-0.000000,'enable_cloud_scroll':[1,1],'gamma':[r1.000000,r0.000000,r0.000000,r1.000000],'glow':[r3.800000,r0.001000,r-0.500000,r1.000000],'haze_density':[r4.000000,r0.000000,r0.000000,r1.000000],'haze_horizon':[r0.650000,r0.000000,r0.000000,r1.000000],'lightnorm':[r-0.309015,r0.000000,r0.951057,r0.000000],'max_y':[r600.000000,r0.000000,r0.000000,r1.000000],'star_brightness':r0.000000,'sun_angle':r1.256639,'sunlight_color':[r0.540000,r0.540000,r0.540000,r0.180000]}

File 2: foggy_sun03_east03

This time east_angle is non-zero and fails as well as sun_angle

2020-04-16T16:20:29Z WARNING #SKY# newview/llsettingsvo.cpp(486) LLSettingsVOSky::buildFromLegacyPreset : Conversion to/from legacy does not match!\nOld: {'ambient':[r0.330000,r0.330000,r0.330000,r0.110000],'blue_density':[r0.145225,r0.399997,r0.800002,r1.000000],'blue_horizon':[r0.430702,r0.853947,r1.000000,r1.000000],'cloud_color':[r0.700000,r0.700000,r0.700000,r0.700000],'cloud_pos_density1':[r0.500000,r0.500000,r0.540000,r1.000000],'cloud_pos_density2':[r0.500000,r0.500000,r0.125000,r1.000000],'cloud_scale':[r0.300000,r0.000000,r0.000000,r1.000000],'cloud_scroll_rate':[r10.499400,r10.011000],'cloud_shadow':[r0.400000,r0.000000,r0.000000,r1.000000],'density_multiplier':[r0.000350,r0.000000,r0.000000,r1.000000],'distance_multiplier':[r4.000000,r0.000000,r0.000000,r1.000000],'east_angle':r1.884954,'enable_cloud_scroll':[1,1],'gamma':[r1.000000,r0.000000,r0.000000,r1.000000],'glow':[r3.800000,r0.001000,r-0.500000,r1.000000],'haze_density':[r4.000000,r0.000000,r0.000000,r1.000000],'haze_horizon':[r0.650000,r0.199156,r0.199156,r1.000000],'lightnorm':[r0.000000,r1.000000,r-0.000000,r0.000000],'max_y':[r600.000000,r0.000000,r0.000000,r1.000000],'preset_num':i18,'star_brightness':r0.000000,'sun_angle':r1.884954,'sunlight_color':[r0.540000,r0.540000,r0.540000,r0.180000]}new:

{'ambient':[r0.330000,r0.330000,r0.330000,r1.000000],'blue_density':[r0.145225,r0.399997,r0.800002,r1.000000],'blue_horizon':[r0.430702,r0.853947,r1.000000,r1.000000],'cloud_color':[r0.700000,r0.700000,r0.700000,r1.000000],'cloud_pos_density1':[r0.500000,r0.500000,r0.540000,r1.000000],'cloud_pos_density2':[r0.500000,r0.500000,r0.125000,r1.000000],'cloud_scale':[r0.300000,r0.000000,r0.000000,r1.000000],'cloud_scroll_rate':[r0.499400,r0.011000],'cloud_shadow':[r0.400000,r0.000000,r0.000000,r1.000000],'density_multiplier':[r0.000350,r0.000000,r0.000000,r1.000000],'distance_multiplier':[r4.000000,r0.000000,r0.000000,r1.000000],'east_angle':r5.026547,'enable_cloud_scroll':[1,1],'gamma':[r1.000000,r0.000000,r0.000000,r1.000000],'glow':[r3.800000,r0.001000,r-0.500000,r1.000000],'haze_density':[r4.000000,r0.000000,r0.000000,r1.000000],'haze_horizon':[r0.650000,r0.000000,r0.000000,r1.000000],'lightnorm':[r0.095491,r0.293891,r0.951057,r0.000000],'max_y':[r600.000000,r0.000000,r0.000000,r1.000000],'star_brightness':r0.000000,'sun_angle':r1.256639,'sunlight_color':[r0.540000,r0.540000,r0.540000,r0.180000]}

Depending which side of the conversion the problem is, this bug may be preventing accurate loading of legacy preset files.

What were you doing when it happened?

What were you expecting to happen instead?

Other information

Attachments

Original Jira Fields
Field Value
Issue BUG-228508
Summary EEP - Asymmetric conversions of sun_angle and east_angle to/from legacy
Type Bug
Priority Unset
Status Closed
Resolution Duplicate
Reporter Chorazin Allen (chorazin.allen)
Created at 2020-04-16T16:38:24Z
Updated at 2020-04-16T18:29:33Z 
{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2020-04-16T13:28:56.523-0500',
  "Is there anything you'd like to add?": '-',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': "The two attached old-style preset files fail the symmetrical conversion tests in llsettingsvo.cpp while creating a new sky by importing legacy presets (this code is ifdef'd off in the source but I've re-enabled it for testing it in a Kokua build, it also needs some minor changes before it'll compile).\r\n\r\nFile 1: foggy_sun 03\r\n\r\nNote that sun_angle fails the test.\r\n\r\n2020-04-16T16:10:01Z WARNING #SKY# newview/llsettingsvo.cpp(486) LLSettingsVOSky::buildFromLegacyPreset : Conversion to/from legacy does not match!\\nOld: {'ambient':[r0.330000,r0.330000,r0.330000,r0.110000],'blue_density':[r0.145225,r0.399997,r0.800002,r1.000000],'blue_horizon':[r0.430702,r0.853947,r1.000000,r1.000000],'cloud_color':[r0.700000,r0.700000,r0.700000,r0.700000],'cloud_pos_density1':[r0.500000,r0.500000,r0.540000,r1.000000],'cloud_pos_density2':[r0.500000,r0.500000,r0.125000,r1.000000],'cloud_scale':[r0.300000,r0.000000,r0.000000,r1.000000],'cloud_scroll_rate':[r10.499400,r10.011000],'cloud_shadow':[r0.400000,r0.000000,r0.000000,r1.000000],'density_multiplier':[r0.000350,r0.000000,r0.000000,r1.000000],'distance_multiplier':[r4.000000,r0.000000,r0.000000,r1.000000],'east_angle':r0.000000,'enable_cloud_scroll':[1,1],'gamma':[r1.000000,r0.000000,r0.000000,r1.000000],'glow':[r3.800000,r0.001000,r-0.500000,r1.000000],'haze_density':[r4.000000,r0.000000,r0.000000,r1.000000],'haze_horizon':[r0.650000,r0.199156,r0.199156,r1.000000],'lightnorm':[r0.000000,r1.000000,r-0.000000,r0.000000],'max_y':[r600.000000,r0.000000,r0.000000,r1.000000],'preset_num':i18,'star_brightness':r0.000000,'sun_angle':r1.884954,'sunlight_color':[r0.540000,r0.540000,r0.540000,r0.180000]}new: \r\n\r\n{'ambient':[r0.330000,r0.330000,r0.330000,r1.000000],'blue_density':[r0.145225,r0.399997,r0.800002,r1.000000],'blue_horizon':[r0.430702,r0.853947,r1.000000,r1.000000],'cloud_color':[r0.700000,r0.700000,r0.700000,r1.000000],'cloud_pos_density1':[r0.500000,r0.500000,r0.540000,r1.000000],'cloud_pos_density2':[r0.500000,r0.500000,r0.125000,r1.000000],'cloud_scale':[r0.300000,r0.000000,r0.000000,r1.000000],'cloud_scroll_rate':[r0.499400,r0.011000],'cloud_shadow':[r0.400000,r0.000000,r0.000000,r1.000000],'density_multiplier':[r0.000350,r0.000000,r0.000000,r1.000000],'distance_multiplier':[r4.000000,r0.000000,r0.000000,r1.000000],'east_angle':r-0.000000,'enable_cloud_scroll':[1,1],'gamma':[r1.000000,r0.000000,r0.000000,r1.000000],'glow':[r3.800000,r0.001000,r-0.500000,r1.000000],'haze_density':[r4.000000,r0.000000,r0.000000,r1.000000],'haze_horizon':[r0.650000,r0.000000,r0.000000,r1.000000],'lightnorm':[r-0.309015,r0.000000,r0.951057,r0.000000],'max_y':[r600.000000,r0.000000,r0.000000,r1.000000],'star_brightness':r0.000000,'sun_angle':r1.256639,'sunlight_color':[r0.540000,r0.540000,r0.540000,r0.180000]}\r\n\r\nFile 2: foggy_sun03_east03\r\n\r\nThis time east_angle is non-zero and fails as well as sun_angle\r\n\r\n2020-04-16T16:20:29Z WARNING #SKY# newview/llsettingsvo.cpp(486) LLSettingsVOSky::buildFromLegacyPreset : Conversion to/from legacy does not match!\\nOld: {'ambient':[r0.330000,r0.330000,r0.330000,r0.110000],'blue_density':[r0.145225,r0.399997,r0.800002,r1.000000],'blue_horizon':[r0.430702,r0.853947,r1.000000,r1.000000],'cloud_color':[r0.700000,r0.700000,r0.700000,r0.700000],'cloud_pos_density1':[r0.500000,r0.500000,r0.540000,r1.000000],'cloud_pos_density2':[r0.500000,r0.500000,r0.125000,r1.000000],'cloud_scale':[r0.300000,r0.000000,r0.000000,r1.000000],'cloud_scroll_rate':[r10.499400,r10.011000],'cloud_shadow':[r0.400000,r0.000000,r0.000000,r1.000000],'density_multiplier':[r0.000350,r0.000000,r0.000000,r1.000000],'distance_multiplier':[r4.000000,r0.000000,r0.000000,r1.000000],'east_angle':r1.884954,'enable_cloud_scroll':[1,1],'gamma':[r1.000000,r0.000000,r0.000000,r1.000000],'glow':[r3.800000,r0.001000,r-0.500000,r1.000000],'haze_density':[r4.000000,r0.000000,r0.000000,r1.000000],'haze_horizon':[r0.650000,r0.199156,r0.199156,r1.000000],'lightnorm':[r0.000000,r1.000000,r-0.000000,r0.000000],'max_y':[r600.000000,r0.000000,r0.000000,r1.000000],'preset_num':i18,'star_brightness':r0.000000,'sun_angle':r1.884954,'sunlight_color':[r0.540000,r0.540000,r0.540000,r0.180000]}new: \r\n\r\n{'ambient':[r0.330000,r0.330000,r0.330000,r1.000000],'blue_density':[r0.145225,r0.399997,r0.800002,r1.000000],'blue_horizon':[r0.430702,r0.853947,r1.000000,r1.000000],'cloud_color':[r0.700000,r0.700000,r0.700000,r1.000000],'cloud_pos_density1':[r0.500000,r0.500000,r0.540000,r1.000000],'cloud_pos_density2':[r0.500000,r0.500000,r0.125000,r1.000000],'cloud_scale':[r0.300000,r0.000000,r0.000000,r1.000000],'cloud_scroll_rate':[r0.499400,r0.011000],'cloud_shadow':[r0.400000,r0.000000,r0.000000,r1.000000],'density_multiplier':[r0.000350,r0.000000,r0.000000,r1.000000],'distance_multiplier':[r4.000000,r0.000000,r0.000000,r1.000000],'east_angle':r5.026547,'enable_cloud_scroll':[1,1],'gamma':[r1.000000,r0.000000,r0.000000,r1.000000],'glow':[r3.800000,r0.001000,r-0.500000,r1.000000],'haze_density':[r4.000000,r0.000000,r0.000000,r1.000000],'haze_horizon':[r0.650000,r0.000000,r0.000000,r1.000000],'lightnorm':[r0.095491,r0.293891,r0.951057,r0.000000],'max_y':[r600.000000,r0.000000,r0.000000,r1.000000],'star_brightness':r0.000000,'sun_angle':r1.256639,'sunlight_color':[r0.540000,r0.540000,r0.540000,r0.180000]}\r\n\r\nDepending which side of the conversion the problem is, this bug may be preventing accurate loading of legacy preset files.",
  'What were you doing when it happened?': '-',
  'What were you expecting to happen instead?': '-',
}
@sl-service-account
Copy link
Author

Dan Linden commented at 2020-04-16T18:28:57Z

Hi Chorazin,
This is most likely a dupe of SL-11077 "[EEP, Simulator] East Angle for windlight is miscalculated by sim", which has been fixed on the Simulator.

That code in the viewer is not used and will not be updated.

Thank you,
Dan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
project:BUG
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sl-service-account