Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

[BUG-228327] [EEP] add LL_DEBUGS("ENVIRONMENT") to llenvironment.cpp #6437

Open
sl-service-account opened this issue Mar 17, 2020 · 10 comments

Comments

@sl-service-account
Copy link

How would you like the feature to work?

Present LL_DEBUGS("ENVIRONMENT") log output is lacking as it doesn't provide data for actual environment elements in use for a given viewer instance. Or, add the actual environment elements to About Secondlife,

Why is this feature important to you? How would it benefit the community?

Need to determine a users actual environment elements for a viewer instance,

Original Jira Fields
Field Value
Issue BUG-228327
Summary [EEP] add LL_DEBUGS("ENVIRONMENT") to llenvironment.cpp
Type New Feature Request
Priority Unset
Status Accepted
Resolution Accepted
Reporter Nicky Perian (nicky.perian)
Created at 2020-03-17T15:19:48Z
Updated at 2020-04-01T18:37:21Z
{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2020-03-18T13:27:46.409-0500',
  'How would you like the feature to work?': 'Present  LL_DEBUGS("ENVIRONMENT") log output is lacking as it doesn\'t provide data for actual environment elements in use for a given viewer instance. Or, add the actual environment elements to About Secondlife,',
  'Original Reporter': 'Nicky Perian (nicky.perian)',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'Target Viewer Version': 'viewer-development',
  'Why is this feature important to you? How would it benefit the community?': 'Need  to determine a users actual environment elements for a viewer instance,',
}
@sl-service-account
Copy link
Author

Kyle Linden commented at 2020-03-18T18:27:46Z

Deferred until next triage.

@sl-service-account
Copy link
Author

Vir Linden commented at 2020-03-25T18:58:31Z

Could you give more specifics here? What info would you like to see and where in the file would we be providing it?

@sl-service-account
Copy link
Author

Nicky Perian commented at 2020-03-26T12:11:11Z, updated at 2020-03-26T12:12:16Z

At setting point for clouds, days, skies, water for local and experience setters. I tried and with limited knowledge all I could resolve was either pointers or the beginning of a uuid. I would like it to display in the same terms a user would see when setting.

@sl-service-account
Copy link
Author

Nicky Perian commented at 2020-03-26T12:22:16Z, updated at 2020-03-26T12:22:53Z

I was in this area when I tried to display with debug.
LLEnvironment::DayInstance::DayInstance(EnvSelection_t env) :
mDayCycle(),
mSky(),
mWater(),
mDayLength(LLSettingsDay::DEFAULT_DAYLENGTH),
mDayOffset(LLSettingsDay::DEFAULT_DAYOFFSET),
mBlenderSky(),
mBlenderWater(),
mInitialized(false),
mType(TYPE_INVALID),
mSkyTrack(1),
mEnv(env),
mAnimateFlags(0)
{ }

LLEnvironment::DayInstance::ptr_t LLEnvironment::DayInstance::clone() const
{
ptr_t environment = std::make_shared(mEnv);

environment->mDayCycle = mDayCycle;
environment->mSky = mSky;
environment->mWater = mWater;
environment->mDayLength = mDayLength;
environment->mDayOffset = mDayOffset;
environment->mBlenderSky = mBlenderSky;
environment->mBlenderWater = mBlenderWater;
environment->mInitialized = mInitialized;
environment->mType = mType;
environment->mSkyTrack = mSkyTrack;
environment->mAnimateFlags = mAnimateFlags;

return environment;

}

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2020-03-30T16:23:36Z

Need to determine a users actual environment elements for a viewer instance,
Just curious why you want to do this?
Is it for debugging possible EEP bugs reported by the user?

@sl-service-account
Copy link
Author

Nicky Perian commented at 2020-03-30T16:27:37Z

Yes.

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2020-03-30T16:47:04Z

What I have been doing is to ask the user if they are using the region environment, the parcel environment or their own custom local environment & if they are using a local environment, ask them to send me a copy of the environment setting & go to the location the user reports the problem at if they are using a parcel/region environment.

For debugging, if you need to be able to see all the settings in a parcel/region environment that you don't have the rights to modify/save, you can get all the settings by dumping the environment cap.

@sl-service-account
Copy link
Author

Nicky Perian commented at 2020-03-30T19:24:58Z, updated at 2020-03-30T19:25:37Z

How do you dump a cap?

While troubling shooting a few days ago I went to Testy. The environment was set with a yellow haze which was impossible to see through. I wanted the plain English name of that element so I could ban/block or abuse report it. At that time a restart took the viewer back to it.

That is when I thought the English name should be free and available.

How do you AR an offending environment? By the time it's reported by region it could be changed.

Rant
I think it's a bad approach to use experiences, a not widely accepted feature, to knit in with environment.
Rant over.

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2020-03-30T19:55:35Z

Um... I set that custom region environment on Testylvania Sandbox to debug a problem with EEP fog!
That environment is in no way "abusive" - there are no adult-rated textures used for the cloud, sun or moon textures, it was just very foggy!
If you don't like the EEP environment on a parcel or region, you can override it locally.
Also, I am not forcing you to see that environment on Testylvania Sandbox with an experience - it is a bog-standard custom EEP region environment that you are free to locally override.
I use Testylvania Sandbox to do most of my EEP debugging, so expect to see some weird & wonderful EEP environments set on that region and in various parcels in that region.

I honestly can't believe you are serious about wanting to abuse report that region environment Nicky LOL.

@sl-service-account
Copy link
Author

Nicky Perian commented at 2020-03-30T20:55:19Z

I have in the past filed abuse reports on particle emitters that caused excessive lag. I would never ever file one from Testylvania Sandbox. That is an example of possible use of the environment plain English names.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant