Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-227796] id_to_time_map_t should use F64 #5996

Closed
sl-service-account opened this issue Oct 25, 2019 · 1 comment
Closed

[BUG-227796] id_to_time_map_t should use F64 #5996

sl-service-account opened this issue Oct 25, 2019 · 1 comment

Comments

@sl-service-account
Copy link

What just happened?

id_to_time_map_t currently uses a F32 to store LLDate::now().secondsSinceEpoch() (llrecentpeople.cpp/.h and called from llpanelpeople.cpp)

The F32 is losing precision resulting in incorrect comparison results from the comparator function for time seen

What were you doing when it happened?

Bug hunting. With the addition of extra debugging, the value being stored into the map isn't the same as the value coming out of due to loss of precision on the F32.

What were you expecting to happen instead?

The Nearby tab of the People panel to sort correctly by time seen

Other information

Original Jira Fields
Field Value
Issue BUG-227796
Summary id_to_time_map_t should use F64
Type Bug
Priority Unset
Status Closed
Resolution Accepted
Reporter Chorazin Allen (chorazin.allen)
Created at 2019-10-25T03:11:48Z
Updated at 2020-05-04T16:06:16Z
{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2019-10-25T12:46:54.465-0500',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'id_to_time_map_t currently uses a F32 to store LLDate::now().secondsSinceEpoch() (llrecentpeople.cpp/.h and called from llpanelpeople.cpp)\r\n\r\nThe F32 is losing precision resulting in incorrect comparison results from the comparator function for time seen',
  'What were you doing when it happened?': "Bug hunting. With the addition of extra debugging, the value being stored into the map isn't the same as the value coming out of due to loss of precision on the F32.",
  'What were you expecting to happen instead?': 'The Nearby tab of the People panel to sort correctly by time seen',
  'Where': 'N/A',
}
@sl-service-account
Copy link
Author

Kyle Linden commented at 2019-10-25T17:46:54Z

Thanks for the report!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant