Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-226648] Point lights are not creating specular reflections on water #5138

Open
1 task
sl-service-account opened this issue Apr 2, 2019 · 2 comments
Open
1 task

Comments

@sl-service-account
Copy link

sl-service-account commented Apr 2, 2019

What just happened?

Another one just for tracking. PR is here: https://bitbucket.org/rider_linden/viewer-eep/pull-requests/update/322

In older versions of the viewer, specular reflections would be generated on water by point lights and projectors.

Due to the brightness of specular highlights in ALM however, this features was removed. Not helping matters was the fact that normals were not being encoded in the appropriate space.

This fix does two things:

  • It re-enables specular on the water plane
  • It scales specular on the water plane so that bloom and specular highlights aren't brighter than they are without ALM

What were you doing when it happened?

Poking around shaders.

What were you expecting to happen instead?

To not poke around shaders.

Other information

Links

Related

Original Jira Fields
Field Value
Issue BUG-226648
Summary Point lights are not creating specular reflections on water
Type Bug
Priority Unset
Status Accepted
Resolution Accepted
Labels whirly-eep
Reporter Geenz Spad (geenz.spad)
Created at 2019-04-02T06:58:20Z
Updated at 2020-06-15T15:23:13Z
{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2019-04-02T08:39:11.876-0500',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': "Another one just for tracking. PR is here: https://bitbucket.org/rider_linden/viewer-eep/pull-requests/update/322\r\n\r\nIn older versions of the viewer, specular reflections would be generated on water by point lights and projectors.\r\n\r\nDue to the brightness of specular highlights in ALM however, this features was removed.  Not helping matters was the fact that normals were not being encoded in the appropriate space.\r\n\r\nThis fix does two things:\r\n* It re-enables specular on the water plane\r\n* It scales specular on the water plane so that bloom and specular highlights aren't brighter than they are without ALM",
  'What were you doing when it happened?': 'Poking around shaders.',
  'What were you expecting to happen instead?': 'To not poke around shaders.',
}
@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2019-04-02T13:39:12Z

Heya Geenz, will this fix BUG-5583?

@sl-service-account
Copy link
Author

Geenz Spad commented at 2019-04-02T16:00:29Z

It does, more or less.  Though I'm not clear on what they mean exactly by supporting materials in reflections - that was always a "maybe in the future" sort of thing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant