Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

[BUG-226646] [EEP] Atmospherics is being applied twice to water in ALM #5136

Open
sl-service-account opened this issue Apr 2, 2019 · 0 comments

Comments

@sl-service-account
Copy link

What just happened?

Water is being applied more than once to water causing a significant "washout" effect to water. Atmospherics is being applied already in softenLightF.glsl (in both class1 and class2). I am submitting a fix by removing the atmospherics in waterF.glsl under class 1.

I've created this bug largely for tracking. There is an associated PR here: https://bitbucket.org/rider_linden/viewer-eep/pull-requests/322/water-plane-rendering-improvements/diff

What were you doing when it happened?

Looking at water.

What were you expecting to happen instead?

Water on legacy WL settings to look about the same in ALM as without it, or at least when compared to another viewer.

Other information

Original Jira Fields
Field Value
Issue BUG-226646
Summary [EEP] Atmospherics is being applied twice to water in ALM
Type Bug
Priority Unset
Status Accepted
Resolution Accepted
Labels whirly-eep
Reporter Geenz Spad (geenz.spad)
Created at 2019-04-02T06:37:27Z
Updated at 2020-06-15T15:23:24Z
{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'Water is being applied more than once to water causing a significant "washout" effect to water.  Atmospherics is being applied already in softenLightF.glsl (in both class1 and class2).  I am submitting a fix by removing the atmospherics in waterF.glsl under class 1.\r\n\r\nI\'ve created this bug largely for tracking.  There is an associated PR here: https://bitbucket.org/rider_linden/viewer-eep/pull-requests/322/water-plane-rendering-improvements/diff',
  'What were you doing when it happened?': 'Looking at water.',
  'What were you expecting to happen instead?': 'Water on legacy WL settings to look about the same in ALM as without it, or at least when compared to another viewer.',
}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant