You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
Due to modifications in the way the viewer handles gamma correction, environment maps are now washed out causing shiny objects to look "overbrightened."
I've applied a fix by sampling environment maps when the deferred renderer is enabled in the sRGB color space. Unlike the older shader based method, this utilizes hardware sampling. The performance difference on modern GPUs is negligible (and if there was a noticeable difference, it would be for the better given that sRGB sampling is largely "for free" thanks to some dedicated silicon).
Screenshots attached. Left is the current unmodified EEP viewer, right is the fixed viewer.
PR incoming.
What were you doing when it happened?
Just checking out EEP. Happened to notice shiny objects were... very unusually shiny.
What were you expecting to happen instead?
Shiny to be not washed out, and to not be overpowering on all content.
EEP - Reflections are not in the correct color space
Type
Bug
Priority
Unset
Status
Closed
Resolution
Accepted
Labels
whirly-eep
Reporter
Geenz Spad (geenz.spad)
Created at
2019-03-29T17:39:50Z
Updated at
2020-06-15T15:23:27Z
{
'Build Id': 'unset',
'Business Unit': ['Platform'],
'Date of First Response': '2019-03-29T19:34:28.424-0500',
"Is there anything you'd like to add?": 'I have this (along with a light gamma correction fix) in a repo located here: https://bitbucket.org/Geenz/viewer-eep',
'ReOpened Count': 0.0,
'Severity': 'Unset',
'System': 'SL Viewer',
'Target Viewer Version': 'viewer-development',
'What just happened?': 'Due to modifications in the way the viewer handles gamma correction, environment maps are now washed out causing shiny objects to look "overbrightened."\r\n\r\nI\'ve applied a fix by sampling environment maps when the deferred renderer is enabled in the sRGB color space. Unlike the older shader based method, this utilizes hardware sampling. The performance difference on modern GPUs is negligible (and if there was a noticeable difference, it would be for the better given that sRGB sampling is largely "for free" thanks to some dedicated silicon).\r\n\r\nScreenshots attached. Left is the current unmodified EEP viewer, right is the fixed viewer.\r\n\r\nPR incoming.',
'What were you doing when it happened?': 'Just checking out EEP. Happened to notice shiny objects were... very unusually shiny.',
'What were you expecting to happen instead?': 'Shiny to be not washed out, and to not be overpowering on all content.',
}
The text was updated successfully, but these errors were encountered:
What just happened?
Due to modifications in the way the viewer handles gamma correction, environment maps are now washed out causing shiny objects to look "overbrightened."
I've applied a fix by sampling environment maps when the deferred renderer is enabled in the sRGB color space. Unlike the older shader based method, this utilizes hardware sampling. The performance difference on modern GPUs is negligible (and if there was a noticeable difference, it would be for the better given that sRGB sampling is largely "for free" thanks to some dedicated silicon).
Screenshots attached. Left is the current unmodified EEP viewer, right is the fixed viewer.
PR incoming.
What were you doing when it happened?
Just checking out EEP. Happened to notice shiny objects were... very unusually shiny.
What were you expecting to happen instead?
Shiny to be not washed out, and to not be overpowering on all content.
Other information
I have this (along with a light gamma correction fix) in a repo located here: https://bitbucket.org/Geenz/viewer-eep
Attachments
Original Jira Fields
The text was updated successfully, but these errors were encountered: