Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

[BUG-226617] EEP - Point and projector light colors are not being submitted in the correct color space #5111

Closed
1 task
sl-service-account opened this issue Mar 29, 2019 · 2 comments

Comments

@sl-service-account
Copy link

sl-service-account commented Mar 29, 2019

What just happened?

Point and projector light colors are not presently being submitted to shaders in the correct color space. As it stands, they are being submitted as if they are already in a linear space when the reality is they are being authored in a non-linear (typically sRGB) color space.

This is important for two reasons: first off, the color you pick in the build floater is not the color that is projected from a given light source in-world. Second: prior to EEP light sources were assumed to be in a non-linear "gamma space" that needed to be transformed into the appropriate linear space for lighting, and were transformed as such in the every frame for every visible light. As a general rule with gamma correct rendering, content authored in one color space should stay in that color space - light colors being no exception.

Attached are some screenshots. From left to right: the current version of EEP in an unmodified form, and a "fixed" version that applies the appropriate transformation on the CPU (and caches it in order to reduce the runtime cost of the old per-frame setup.)

PR incoming.

What were you doing when it happened?

Just checking out EEP. Happened to notice lights were looking a bit weirder than usual.

What were you expecting to happen instead?

Light colors to not be washed out.

Other information

I have this (along with a reflection gamma correction fix) in a repo located here: https://bitbucket.org/Geenz/viewer-eep

Attachments

Links

Related

Original Jira Fields
Field Value
Issue BUG-226617
Summary EEP - Point and projector light colors are not being submitted in the correct color space
Type Bug
Priority Unset
Status Closed
Resolution Accepted
Labels whirly-eep
Reporter Geenz Spad (geenz.spad)
Created at 2019-03-29T17:25:39Z
Updated at 2021-10-28T14:33:38Z
{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2019-03-29T19:34:28.251-0500',
  "Is there anything you'd like to add?": 'I have this (along with a reflection gamma correction fix) in a repo located here: https://bitbucket.org/Geenz/viewer-eep',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'Point and projector light colors are not presently being submitted to shaders in the correct color space.  As it stands, they are being submitted as if they are already in a linear space when the reality is they are being authored in a non-linear (typically sRGB) color space.\r\n\r\nThis is important for two reasons: first off, the color you pick in the build floater is not the color that is projected from a given light source in-world.  Second: prior to EEP light sources were assumed to be in a non-linear "gamma space" that needed to be transformed into the appropriate linear space for lighting, and were transformed as such in the every frame for every visible light. As a general rule with gamma correct rendering, content authored in one color space should stay in that color space - light colors being no exception.\r\n\r\nAttached are some screenshots.  From left to right: the current version of EEP in an unmodified form, and a "fixed" version that applies the appropriate transformation on the CPU (and caches it in order to reduce the runtime cost of the old per-frame setup.)\r\n\r\nPR incoming.',
  'What were you doing when it happened?': 'Just checking out EEP.  Happened to notice lights were looking a bit weirder than usual.',
  'What were you expecting to happen instead?': 'Light colors to not be washed out.',
}
@sl-service-account
Copy link
Author

Jeffbot Linden commented at 2019-03-30T00:34:28Z

Mentioned in build 525821 for DRTVWR-440 (EEP: Windlight Environment Viewer Changes)

  • fe0c8b37cacb : BUG-226611, BUG-226617, BUG-226618: Update contrib file for Geenz Spad

@sl-service-account
Copy link
Author

Jeffbot Linden commented at 2019-04-22T14:22:08Z

Mentioned in build 526491 for DRTVWR-477 (Muscadine - follow-on work for animesh and other 3D content)

  • fe0c8b37cacb : BUG-226611, BUG-226617, BUG-226618: Update contrib file for Geenz Spad

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant