Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

[BUG-226611] EEP - Sunlight color appears to be broken #5108

Closed
sl-service-account opened this issue Mar 29, 2019 · 2 comments
Closed

[BUG-226611] EEP - Sunlight color appears to be broken #5108

sl-service-account opened this issue Mar 29, 2019 · 2 comments

Comments

@sl-service-account
Copy link

sl-service-account commented Mar 29, 2019

What just happened?

Sunlight contribution appears to be broken. See attached screenshots. It appears mid levels aren't being correctly represented potentially meaning that gamma correction is not functioning correctly under EEP. A similar problem existed on point and spot lights. I have fixed it in a separate repo.

What were you doing when it happened?

Fixing point and spot lights in EEP. During my testing I thought to test the sun and moon light contributions. The results (with the environment floater with the currently selected colors displayed) are shown in the screenshots below.

What were you expecting to happen instead?

The raw sun and moon contributions to match the colors that I have input.

Other information

The most straightforward way to test this is to open the softenLightF.glsl shaders in class1 and class2, overwrite col.rgb with sun_contrib after the water fog has been applied, and start messing with the sun light settings. Note that it does not matter what the ambient, blue horizon, or blue density colors are nor the scene gamma. The result will be the same.

Attachments

Original Jira Fields
Field Value
Issue BUG-226611
Summary EEP - Sunlight color appears to be broken
Type Bug
Priority Unset
Status Closed
Resolution Accepted
Labels whirly-eep
Reporter Geenz Spad (geenz.spad)
Created at 2019-03-29T15:32:29Z
Updated at 2020-06-15T15:23:13Z
{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2019-03-29T19:34:28.054-0500',
  "Is there anything you'd like to add?": 'The most straightforward way to test this is to open the softenLightF.glsl shaders in class1 and class2, overwrite col.rgb with sun_contrib after the water fog has been applied, and start messing with the sun light settings.  Note that it does not matter what the ambient, blue horizon, or blue density colors are nor the scene gamma.  The result will be the same.',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': "Sunlight contribution appears to be broken.  See attached screenshots.  It appears mid levels aren't being correctly represented potentially meaning that gamma correction is not functioning correctly under EEP.  A similar problem existed on point and spot lights.  I have fixed it in a separate repo.",
  'What were you doing when it happened?': 'Fixing point and spot lights in EEP.  During my testing I thought to test the sun and moon light contributions.  The results (with the environment floater with the currently selected colors displayed) are shown in the screenshots below.',
  'What were you expecting to happen instead?': 'The raw sun and moon contributions to match the colors that I have input.',
  'Where': 'Hippo Hollow',
}
@sl-service-account
Copy link
Author

Jeffbot Linden commented at 2019-03-30T00:34:28Z

Mentioned in build 525821 for DRTVWR-440 (EEP: Windlight Environment Viewer Changes)

  • fe0c8b37cacb : BUG-226611, BUG-226617, BUG-226618: Update contrib file for Geenz Spad

@sl-service-account
Copy link
Author

Jeffbot Linden commented at 2019-04-22T14:22:08Z

Mentioned in build 526491 for DRTVWR-477 (Muscadine - follow-on work for animesh and other 3D content)

  • fe0c8b37cacb : BUG-226611, BUG-226617, BUG-226618: Update contrib file for Geenz Spad

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant