Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

[BUG-18248] Water surface not visible looking up while underwater if water level has 2 digits after decimal #2643

Closed
1 task
sl-service-account opened this issue Jun 2, 2016 · 5 comments

Comments

@sl-service-account
Copy link

sl-service-account commented Jun 2, 2016

Steps to Reproduce

Set region water level to 20.57 meters. Get camera view so camera is in the water looking upwards toward the sky.

Actual Behavior

This has to be the oddest error I've run across yet. If you are below water and looking up, you should see the water surface and the sky beyond. However, if your region water level is set to some values that have 2 digits after the decimal point, the surface is not visible, nor is the sky. For example a water level of 20.5 is fine, as is 20.6. However a water level of 20.57 and the surface disappears.

Expected Behavior

Water surface to always be visible (when appropriate graphics options are enabled.)

Other information

Attachments

Links

Related

Original Jira Fields
Field Value
Issue BUG-18248
Summary Water surface not visible looking up while underwater if water level has 2 digits after decimal
Type Bug
Priority Unset
Status Closed
Resolution Accepted
Reporter Phate Shepherd (phate.shepherd)
Created at 2016-06-02T02:34:46Z
Updated at 2020-04-20T16:59:45Z
{
  'Business Unit': ['Platform'],
  'Date of First Response': '2016-06-02T00:07:50.922-0500',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': "This has to be the oddest error I've run across yet. If you are below water and looking up, you should see the water surface and the sky beyond. However, if your region water level is set to a value that has 2 digits after the decimal point, the surface is not visible, nor is the sky. For example a water level of 20.5 is fine, as is 20.6. However a water level of 20.57 and the surface disappears.",
  'What were you doing when it happened?': 'Doing an underwater photoshoot on my sim.',
  'What were you expecting to happen instead?': 'Water surface to always be visible (when appropriate graphics options are enabled.)',
  'Where': 'Private sim',
}
@sl-service-account
Copy link
Author

Chaser Zaks commented at 2016-06-02T05:07:51Z, updated at 2016-06-02T05:24:48Z

Reproducable on

Second Life 4.0.5.315117 (Second Life Release)
Release Notes

You are at 247.2, 34.7, 23.3 in Iwakura located at sim10007.agni.lindenlab.com (216.82.48.17:13002)
SLURL: http://maps.secondlife.com/secondlife/Iwakura/247/35/23
(global coordinates 235,255.0, 314,403.0, 23.3)
Second Life Server 16.05.20.315515
Retrieving...

CPU: Intel(R) Core(TM) i5-3550 CPU @ 3.30GHz (3292.55 MHz)
Memory: 8175 MB
OS Version: Microsoft Windows 7 64-bit Service Pack 1 (Build 7601)
Graphics Card Vendor: ATI Technologies Inc.
Graphics Card: AMD Radeon HD 6700 Series

Windows Graphics Driver Version: 8.17.0010.1404
OpenGL Version: 4.2.13399 Compatibility Profile Context 15.201.1151.1010

J2C Decoder Version: KDU v7.2
Audio Driver Version: FMOD Ex 4.44.31
LLCEFLib/CEF Version: 1.5.3-(CEF-WIN-3.2526.1347-32)
Voice Server Version: Vivox 4.6.0017.22050

Packets Lost: 5/2,385 (0.2%)

No errors generated by log relating to water and floating point precision.
I'm going out on a limb here, and have checked the code and seeing no reason why, I'm going to blame it on floating point precision. 20.5 = 20.5, 20.57 = 20.56999969482422. Probably in the shaders, I don't like shaders and they don't like me so I am not touching it.

@sl-service-account
Copy link
Author

Phate Shepherd commented at 2016-06-02T11:34:44Z

I think you are on to something. It sounds like some bizarro fp precision error.

20.51 - fails
20.52 - fails
20.53 - fails
20.54 - works
20.55 - works
20.56 - works
20.57 - fails
20.58 - works
20.59 - works

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2016-06-02T16:04:45Z, updated at 2016-06-02T16:54:56Z

Wow good catch Phate!
You just solved a mystery for me too - we had someone contact Firestorm support about this problem & we didn't spot it was the water level causing it.
Just confirmed that was indeed this bug so thank you!

@sl-service-account
Copy link
Author

Phate Shepherd commented at 2016-06-02T17:43:53Z

Thanks Whirly, yeh, that was an odd one!

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2019-04-22T13:24:27Z

This bug seems fixed with EEP.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant