[BUG-139291] Windows product key not suitable as unique machine key #2487
Comments
Chaser Zaks commented at 2017-10-25T00:09:35Z WMIC seems to be able to get the motherboard serial number. Maybe the viewer can use the same technique to query the motherboard and use that? |
Ansariel Hiller commented at 2017-10-25T07:05:52Z The motherboard serial number is an optional field and it is up to the manufacturer or OEM to set this value. So this might work for some models and some other models may not have it set or have it set to the same value. |
Chorazin Allen commented at 2020-11-01T23:24:48Z Bump: This is still very much an issue - this is happening again with the Windows 10 2004 and 20H2 feature updates currently rolling out. |
Anastasia Horngold commented at 2020-11-27T22:22:24Z I'm not sure this is the right place to add this, but this of course is also an issue on Macs. And it doesn't happen only when I upgrade my OS. Every time I switch from wifi to ethernet on my laptop, I have to reenter my logins - and that can be multiple times a day. |
Chorazin Allen commented at 2020-11-27T22:33:54Z See also linked issue BUG-229637 ... MAC address could be used for all platforms so long as the code gets smarter about avoiding randomised wifi MAC addresses |
AndreyK ProductEngine commented at 2020-12-04T10:16:16Z [~anastasia.horngold]
If possible, please report this MacOs issue in separate jira. |
Whirly Fizzle commented at 2020-12-06T17:53:09Z Ref: https://bitbucket.org/lindenlab/viewer/pull-requests/403/sl-14270-windows-product-key-not-suitable |
Whirly Fizzle commented at 2020-12-06T21:42:02Z Mac issue filed at BUG-229799 |
AndreyK ProductEngine commented at 2020-12-07T09:39:48Z Thanks! |
AndreyK ProductEngine commented at 2021-07-23T06:30:38Z Change to use motherboard guid is in DRTVWR-521 - Maintenance: Grappa |
Currently, the viewer uses the unique Windows serial number (aka Windows product key) to encrypt the salt used in encrypting the credentials of the user on the user's PC. Previously, the MAC address of the first network adapter was used for this, but with the change in the network infrastructure in Windows 7, the MAC address was replaced by the Windows serial number. (See S32 LLMachineID::init()
for details)
However, as with Windows 10, this creates a new issue: Installing a feature update in Windows 10, e.g. the current Fall Creators Update, changes the Windows serial number. As a result, the viewer is unable to decrypt the stored credentials after each Windows feature update. This is a highly undesirable situation. Installing a Windows feature update (which is going to happen twice a year) shouldn't result in having the user enter their credentials again.
TL;DR: A new unique machine key is needed to replace the Windows serial number.
Attachments
Links
Related
Original Jira Fields
The text was updated successfully, but these errors were encountered: