Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[BUG-10684] [Valhalla] Flash plugin will not load #987

Open
2 tasks
sl-service-account opened this issue Nov 12, 2015 · 14 comments
Open
2 tasks

[BUG-10684] [Valhalla] Flash plugin will not load #987

sl-service-account opened this issue Nov 12, 2015 · 14 comments
Labels
project:BUG

Comments

@sl-service-account
Copy link

sl-service-account commented Nov 12, 2015 •
edited by sl-issues-importer bot

Steps to Reproduce

Load any page that uses flash, especially streaming websites like twitch.tv after installing the PPAPI flash plugin from the Adobe website.

Actual Behavior

The new CEF based browser does not load the system-wide flash player install by default.

Expected Behavior

The CEF plugin should be looking in the default system install location for installed PPAPI flash plugins. It fails to do so.

Other information

This can be easily fixed by passing the command line flag --enable-system-flash to llceflib_host.exe

See the screenshot for the official CEF test program running with this command line arguement: Flash loads successfully. Below that is Second Life Valhalla running on the same system. No flash version loaded, and the command line (when checking the running llceflib_host.exe in task manager) lacks the --enable-system-flash flag.

I see no reason to not include this in the code. It should work on Windows and OS X. Linux users would have to manually provide the version and location of their flash plugin. Would be nice to have this as a debug setting for advanced users. See the comments here for detail: https://bitbucket.org/chromiumembedded/cef/issues/1586/add-pepper-flash-plugin-support

Maintaining the capability is as simple as keeping CEF up to date, if I understand the architecture of how MOAP works.
This will ensure compatibility for the many, many websites that still utilize flash, using the flash player that chromium itself uses.

(Edited, as ceflib_host.exe is now llceflib_host.exe)

Attachments

Links

Related

Original Jira Fields
Field Value
Issue BUG-10684
Summary [Valhalla] Flash plugin will not load
Type Bug
Priority Unset
Status Accepted
Resolution Accepted
Reporter Maloo Eliot (maloo.eliot)
Created at 2015-11-12T18:47:37Z
Updated at 2017-05-08T23:49:52Z 
{
  'Business Unit': ['Platform'],
  'Date of First Response': '2015-12-01T11:55:31.421-0600',
  "Is there anything you'd like to add?": 'This can be easily fixed by passing the command line flag --enable-system-flash to ceflib_host.exe\r\n\r\nSee the screenshot for the official CEF test program running with this command line arguement: Flash loads successfully. Below that is Second Life Valhalla running on the same system. No flash version loaded, and the command line lacks the --enable-system-flash flag.\r\n\r\nI see no reason to not include this in the code. It should work on Windows and OS X. Linux users would have to manually provide the version and location of their flash plugin. Would be nice to have this as a debug setting for advanced users. Maintaining the capability is as simple as keeping CEF up to date, if I understand the architecture of how MOAP works.\r\n\r\nThis will ensure compatibility for the many, many websites that still utilize flash, using the flash player that chromium itself uses.',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'The new CEF based browser does not load the system-wide flash player install by default. ',
  'What were you doing when it happened?': 'Load any page that uses flash, especially streaming websites like twitch.tv',
  'What were you expecting to happen instead?': 'The CEF plugin should be looking in the default system install location for installed PPAPI flash plugins. It fails to do so.',
  'Where': 'Can be viewed at chrome://version/',
}
@sl-service-account
Copy link
Author

Kyle Linden commented at 2015-12-01T17:55:31Z

Hello Maloo,

Please try again with the latest Valhalla viewer http://wiki.secondlife.com/wiki/Linden_Lab_Official:Alternate_Viewers

Press the Info Provided button when you have updated this issue.

Thanks!

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2015-12-01T19:20:08Z

Flash is not working on the latest Valhalla-RC for me: Second Life 4.0.0 (307894) Nov 16 2015 17:02:00 (Second Life Release).
I have plugins enabled in Preferences and I also have working flash media with default release webkit & also Firestorm CEF merge, so I believe everything is set up correctly at my end for flash.
--enable-system-flash command line flag is not recognised on 4.0.0.307894
I don't see a new debug setting for enabling flash.

Am I missing something?

Second Life 4.0.0 (307894) Nov 16 2015 17:02:00 (Second Life Release)
Release Notes

CPU: Intel(R) Core(TM) i7-4770K CPU @ 3.50GHz (3491.96 MHz)
Memory: 16268 MB
OS Version: Microsoft Windows 7 64-bit Service Pack 1 (Build 7601)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: GeForce GTX 750/PCIe/SSE2

Windows Graphics Driver Version: 10.18.0013.5900
OpenGL Version: 4.5.0 NVIDIA 359.00

libcurl Version: libcurl/7.38.0 OpenSSL/1.0.1h zlib/1.2.8
J2C Decoder Version: KDU v7.2
Audio Driver Version: FMOD Ex 4.44.31
LLCEFLib/CEF Version: 1.4.0-(CEF-WIN-3.2526.1347-32)
Voice Server Version: Not Connected
Built with MSVC version 1800

@sl-service-account
Copy link
Author

Maloo Eliot commented at 2015-12-01T19:30:47Z, updated at 2015-12-01T19:34:31Z

(accidental double post.)

@sl-service-account
Copy link
Author

Maloo Eliot commented at 2015-12-01T19:34:10Z, updated at 2015-12-01T19:44:59Z

Tried again with the current version: It appears that no changes in the latest viewer have affected the issue, the same behavior persists.

Second Life 4.0.0 (307894) Nov 16 2015 17:02:00 (Second Life Release)
Release Notes

[Location removed for privacy]

CPU: Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz (4000 MHz)
Memory: 16260 MB
OS Version: Microsoft Windows 7 64-bit Service Pack 1 (Build 7601)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: GeForce GTX 780/PCIe/SSE2

Windows Graphics Driver Version: 10.18.0013.5900
OpenGL Version: 4.5.0 NVIDIA 359.00

libcurl Version: libcurl/7.38.0 OpenSSL/1.0.1h zlib/1.2.8
J2C Decoder Version: KDU v7.2
Audio Driver Version: FMOD Ex 4.44.31
LLCEFLib/CEF Version: 1.4.0-(CEF-WIN-3.2526.1347-32)
Voice Server Version: Vivox 4.6.0017.21209

Built with MSVC version 1800
Packets Lost: 0/3,329 (0.0%)

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2015-12-01T19:40:27Z, updated at 2015-12-01T19:41:05Z

I'm presuming I'm doing something wrong.
I grabbed the latest CEF build from http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/viewer-cef_viewer-cef/rev/308430/index.html, which I presume should certainly include this change https://bitbucket.org/lindenlab/3p-llceflib/commits/d036840a83d003c02ac2fade8a3accbf6fc1366d, which adds support for the enable-system-flash command line.

I set my shortcut target path to ```Java
"I:\Program Files\Secondlife-Project-VALHALLA\SecondLifeViewer\SecondLifeViewer.exe" --set InstallLanguage en --enable-system-flash

@sl-service-account
Copy link
Author

Maloo Eliot commented at 2015-12-01T19:44:49Z

--enable-system-flash is something that the llceflib_host.exe process would recognize, not the second life executable. Since the process is started by the viewer, we have no way of passing it to the plugin without changing the viewer's code.

@sl-service-account
Copy link
Author

Maloo Eliot commented at 2015-12-01T19:58:02Z

Read the commit that Whirly posted more closely. Looks like the flag, in the current version, is added when the enable plugins box is checked. I had assumed it was still checked from the previous version.

While I was about to test again, it appears that 4.0 went public. Same build, so no changes, I assume.

Checking enable plugins does not work, either immediately, or after restarting the viewer.
Either the change that Whirly mentioned above wasn't included in this release, or it's not functioning correctly.

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2015-12-01T21:22:01Z

Hmm somthing doesn't appear right with the BrowserPluginsEnabled setting.
On 4.0.0.3078430, the settings.xml file in app_settings (I:\Program Files\Secondlife-Project-VALHALLA\SecondLifeViewer\app_settings\settings.xml) has:

    <key>BrowserPluginsEnabled</key>
    <map>
      <key>Comment</key>
      <string>Enable Web plugins in the built-in Web browser?</string>
      <key>Persist</key>
      <integer>1</integer>
      <key>Type</key>
      <string>Boolean</string>
      <key>Value</key>
      <integer>0</integer>

Doesn't this mean BrowserPluginsEnabled will be persistantly disabled each login which will override the user settings file?

Default release has:

    <key>BrowserPluginsEnabled</key>
    <map>
      <key>Comment</key>
      <string>Enable Web plugins in the built-in Web browser?</string>
      <key>Persist</key>
      <integer>1</integer>
      <key>Type</key>
      <string>Boolean</string>
      <key>Value</key>
      <integer>1</integer>
    </map>

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2015-12-07T23:51:56Z, updated at 2015-12-07T23:52:10Z

Flash is still not working for me on the new Valhalla build: http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Release/4.0.0.308641

The BrowserPluginsEnabled setting funkiness has been fixed though.
BrowserPluginsEnabled is enabled by default now.

I still have working flash media on default release so I'm pretty sure everything is set up correctly at my end to play flash media.

Is flash supposed to work on this build?
I see there's a fix in the resolved issues: "MAINT-5941 [Valhalla] Default flash to on by default"
Do I need to do anything at my end to enable flash for CEF?

http://i.prntscr.com/42f451b14d65415f8bfc9fdb184ee2e8.png

Second Life 4.0.0 (308641) Dec  4 2015 12:20:51 (Second Life Release)
Release Notes

You are at 99.2, 143.5, 21.1 in Testylvania Sandbox located at sim8922.agni.lindenlab.com (216.82.41.98:12035)
SLURL: http://maps.secondlife.com/secondlife/Testylvania%20Sandbox/99/144/21
(global coordinates 332,643.0, 306,320.0, 21.1)
Second Life Server 15.11.13.307797
Release Notes

CPU: Intel(R) Core(TM) i7-4770K CPU @ 3.50GHz (3491.96 MHz)
Memory: 16268 MB
OS Version: Microsoft Windows 7 64-bit Service Pack 1 (Build 7601)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: GeForce GTX 750/PCIe/SSE2

Windows Graphics Driver Version: 10.18.0013.5906
OpenGL Version: 4.5.0 NVIDIA 359.06

libcurl Version: libcurl/7.38.0 OpenSSL/1.0.1h zlib/1.2.8
J2C Decoder Version: KDU v7.2
Audio Driver Version: FMOD Ex 4.44.31
LLCEFLib/CEF Version: 1.4.0-(CEF-WIN-3.2526.1347-32)
Voice Server Version: Vivox 4.6.0017.21209

Built with MSVC version 1800
Packets Lost: 916/21,265 (4.3%)

@sl-service-account
Copy link
Author

Callum Linden commented at 2015-12-08T19:27:34Z

Hi Whirly - presumably at some point, you installed the Flash plugin manually. I used the Adobe installer from here: https://get.adobe.com/flashplayer/ - and I see the Flash plugin files (npswf*.dll) in my Windows\Sys\WOW64\Macromed\Flash folder.

That is what my CEF viewer is using and everything seems to work for me - Flash games load, version number reports the same etc.

Can you see if your version is in the same place? If not, although I'm a bit hesitant to try in case - maybe you can try installing Flash again from that URL above and see if that helps.

Thanks!

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2015-12-08T22:33:56Z

Heya Callum,

Yes I installed Flash plugin manually a long time ago.
I have the flash plugin version installed that's needed to have working flash with default webkit viewers - so that's the Firefox version of the Adobe Flash plugin.
So, using Firefox browser, I went to http://get.adobe.com/flashplayer/otherversions/ and chose these options http://prntscr.com/9bxfog.
This gave me working flash media on default release, Firestorm & other old webkit based viewers.

These are the files in my C:\Windows\SysWOW64\Macromed\Flash
http://i.imgur.com/iQ8byZC.png

I'll reinstall flash again now & make sure I have the latest version & update in a bit.

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2015-12-08T23:00:46Z

I now have working flash on valhalla after doing the following:

The contents of my C:\Windows\SysWOW64\Macromed\Flash folder are now:
http://i.imgur.com/0o8BT8i.png

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2015-12-08T23:36:39Z

  • I uninstalled both versions of the flash plugin & verified flash media was broken on both Valhalla and webkit viewers.
  • I then reinstalled only the "FP 20 for Opera & Chromium - PPAPI" version using http://get.adobe.com/flashplayer/otherversions/ in Firefox broswer.
  • This gives me working flash on Valhalla but flash is broken on older webkit viewers.

@sl-service-account
Copy link
Author

Whirly Fizzle commented at 2015-12-08T23:50:12Z

Here are the steps needed to have working Flash media on a clean Windows system which does not have Flash installed.
You will need different versions of the Flash plugin for the CEF based and the older Webkit based viewers.
The order you install the Flash plugins does not matter.

Installing Flash plugins for CEF/Valhalla

  • Using Firefox web browser, go to http://get.adobe.com/flashplayer/otherversions/
  • Choose the correct operating system under Step 1.
  • Choose FP 20 for Opera & Chromium - PPAPI under Step 2.
  • Install Flash.
  • Make sure that "Enable Plugins" is ticked under viewer Preferences -> Setup -> Enable Plugins.
  • You need to restart the viewer if logged in while installing Flash.

Installing Flash plugins for older Webkit based viewers

  • Using Firefox web browser, go to http://get.adobe.com/flashplayer/otherversions/
  • Choose the correct operating system under Step 1.
  • Choose FP 20 for Firefox - NPAPI under Step 2.
  • Install Flash.
  • Make sure that "Enable Plugins" is ticked under viewer Preferences -> Setup -> Enable Plugins.
  • You need to restart the viewer if logged in while installing Flash.

Verified this works on Windows 7 64bit.

This was referenced Feb 14, 2024
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
project:BUG
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sl-service-account