• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: WEB-380
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Normal Normal
Assignee: Unassigned
Reporter: Ordinal Malaprop
Votes: 29
Watchers: 6
Operations

If you were logged in you would be able to see more operations.
3. Second Life Website - WEB

"Fixed Internally" should not appear as "Resolved" in JIRA; voting should continue

Created: 13/Nov/07 02:27 PM   Updated: 31/Dec/07 09:33 AM
Return to search
Component/s: jira.secondlife.com
Affects Version/s: Not Versioned
Fix Version/s: None

Environment: All
Issue Links:
Relates
 

Linden Lab Issue ID: DEV-6591


 Description  « Hide
Currently, JIRA issues which are "fixed internally" get a status of "resolved", which prevents any further voting, regardless of whether the fix has actually been applied. This is a problem for two main reasons as I see it.

1. The issue has not actually been resolved, it is still active until a fix has been applied to a release client. The classification of "resolved" is therefore not only terminologically incorrect but could also confuse both readers and, dare I say it, potential fixers. Residents may start bug reports as they see in their client that the issue is still present, and it may be sidelined for fixing within LL. No issue should be called "resolved" until it actually has been in practice.

2. Marking an issue as "resolved", as mentioned, prevents further voting. However, this provides incomplete information. If the issue is still very much live on the grid and is still causing problems - say, it has been recently used in a widespread grid attack, and only recently people have become aware of it - votes for its importance should be recorded and used to determine priorities, as with an issue that is not "fixed internally". To users it makes no difference that a potential fix exists in theory but has not been applied.

I would propose therefore that "fixed internally" not close the issue and merely be another status prior to the actual resolution, which would be incorporation of the fix into a release client.



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Jacek Antonelli added a comment - 13/Nov/07 03:14 PM
I'm not sure I see the need for a new "semi-resolved" status. Would it be enough if voting were to remain open after the issue is resolved?

Ordinal Malaprop added a comment - 13/Nov/07 03:21 PM
I would say that "fixed internally" should just be another status that is not "resolved", just like "open" and "assigned". As long as it doesn't turn off voting and imply that that is it for that issue, the exact details aren't that important... but something should only be "resolved" if I can go into SL with the latest client and see that it is fixed.

pavig lok added a comment - 14/Nov/07 03:50 AM
I agree - when a fix is resolved but not applied it creates ambiguities. One has no indication if or when it will be rolled out. This has caught me out several times when bug tracking. When the jira is the main avenue for folk (many of them non programmers) to track the status of bugs that may effect their products or in world activities it is important for this extra step of implementation to be tracked. Due to other code contingencies a resolved issue doesn't always go straight into the client.

Jacek Antonelli added a comment - 14/Nov/07 10:19 AM
Alright, I'm convinced. "Fixed internally" is definitely more of a "pending" (one might even say "limbo") state than a "resolved" state.

Matthew Dowd added a comment - 18/Nov/07 12:49 AM
There is a lack of transparency when an issue enters LL tracking system.

An issue/patch can be "imported" i.e. makes it into LL internal jira - however, it can then sit their indefinitely without anyone within LL acting upon it.

In the case of "fixed internally", it is not clear what the internal processes within LL are - it can be 2-3 months before a "fixed internally" issue makes it into release (floating text not displaying on non-root prims being an issue which spent a very long time as "fixed internally" before it actually got fixed in release). Some "fixed internally" issues seem to get lost, and it take a few prods (e.g. re-opening the issue on here) before they make it into release.


Prokofy Neva added a comment - 18/Nov/07 01:57 PM
A major problem here is that when a Linden declares something is "fixed internally," some JIRA regulars are rushing to close it and declare it "resolved". But it isn't resolved until it appears functioning and implemented in a live client download.

As Matthew Dowd points out, an "internally resolved" issue has no status. If there are Lindens disagreeing about it (as we have seen sometimes on issues here) then we can expect that one Linden may simply not prevail. Or no Linden may find it a priority.

Therefore the status of "fixed internally" while interesting should never be used to mark an issue RESOLVED and stop its votes until it truly is resolved.


Celierra Darling added a comment - 19/Nov/07 08:05 AM
I think the problem is that the statuses are from the perspective of Linden Lab - the issue is "resolved" because there's nothing left for LL to do until the fix is released.

Linking to WEB-194.


Celierra Darling made changes - 19/Nov/07 08:07 AM
Field Original Value New Value
Link This issue Relates to WEB-194 [ WEB-194 ]
Celierra Darling added a comment - 19/Nov/07 08:07 AM
Adding links to WEB-194 and WEB-296.

Celierra Darling made changes - 19/Nov/07 08:07 AM
Link This issue Relates to WEB-296 [ WEB-296 ]
Celierra Darling made changes - 19/Nov/07 09:48 PM
Link This issue Relates to WEB-247 [ WEB-247 ]
Celierra Darling added a comment - 19/Nov/07 09:48 PM
Also adding WEB-247 while I've thought of it...

Celierra Darling added a comment - 26/Nov/07 11:10 AM
I think this is an insightful post by Nicholaz : http://nicholaz-beresford.blogspot.com/2007/11/long-road-behind-long-road-ahead.html

The part that is relevant to this discussion, I think, is that residents tend to focus upon their experience right now and become frustrated when fixes are delayed a long time, especially when perceived problems are grouped together to be fixed as part of a bigger project.


Fluf Fredriksson added a comment - 26/Nov/07 01:25 PM
A related query ... Does "fixed internally" mean that Linden's are using viewers incorporating the fix?
Just wondered.

/me gazes deeply into his crystal ball ... the mists part briefly ... I see ... a ... "Fix" ... no wait it's getting clearer ... I see a .... "Won't Fix" in your near future.


lindenrobot made changes - 28/Nov/07 05:49 PM
Linden Lab Issue ID DEV-6591
Rob Linden added a comment - 29/Nov/07 04:12 PM
I'm strongly considering adding a new state rather than making this a resolution code, perhaps calling the new state "FIX PENDING" or just "PENDING".

We need to be able to communicate both when an issue has been addressed in the codebase (fixed internally), and when the fix for an issue has been shipped. The former is needed as a signal to developers that no more dev work should be required on the issue, so that non-Linden developers don't waste their time trying to fix an issue that someone already addressed. The latter is needed to signal that "yes, it's truly fixed in a way that you can see for yourself".

We discussed this at the last open source meeting:
https://wiki.secondlife.com/wiki/Open_Source_Meeting/2007-11-29

Abbreviated transcript follows:

  1. [14:34] Rob Linden: ok, how is this for a process
  2. [14:35] Rob Linden: we make sure that any time something gets marked "fixed internally" has a branch and a rev on it
  3. [14:35] Rob Linden: that branch may not mean anything to most people, but....
  4. [14:36] Rob Linden: we then endeavor to keep the list of branches up to date on the wiki for at least the branches referred to in PJIRA
  5. [14:36] Rob Linden: I don't think that we can do that for ALL branches, because there are branches in there which are still confidential work
  6. [14:54] Rob Linden: I think we've got something that will help keep really tech savvy people up to date
  7. [14:54] Rob Linden: ...but will be utterly baffling to everyone else

We're hoping on community help to spread the word beyond that. However, we can revisit if it isn't panning out.

I can't make any promises that we'll make this work as described, because I can't commit to it myself and I don't have minions to delegate it to, but we'll see what we can pull together.

Note: the reason we're considering making a change here has nothing to do with voting. Voting on issues that we've already fixed is of relatively little value. There's a very small chance that if something is really popular, it gets moved to the front of the line, but that would be rare. Generally speaking, moving things to the front of the line short circuits testing, which is a highly risky thing to do.


ZigZag Freenote added a comment - 01/Dec/07 04:51 PM
Pending sounds great.

OK, voting is not likely to push things through, unless of course the votes skyrocket. But at least it keeps a casual victim happy.

For the pending state, I think issues with Critical or Showstopper priority should be updated once a week or two with a short comment on progress, like "we need to test it more", or "this is ready for the next restart", or "awaiting next release", to give the anxious Residents a good feeling. And a chance to ping back so pain issues are not forgotten. SVC-930 was a good candidate for a regular status update.

Ideally, when developer fixes something, he (or the lead engineer, I don't know how that works in LL) would add a one liner roughly telling us where or what was fixed. During the pending state, an issue would be updated regularly, and hopefully a final confirmation would be added when QA verifies it in the RC.

I understand this is additional work, especially with juggling two jiras, but I think it would make everyone happier. Of course the community would need to keep the priority levels down, or this can never work. But anyway it would not be a firm rule. This would be for the issues where LL concurs with the priority.


Montana Corleone added a comment - 15/Dec/07 08:57 AM
How about this: when you fix something internally, you say so, but leave it as it is so people can seee, and put it on a big Post-It on your screen with: Remember to put his fixed issue in the next update? There are quite a few "fixed issues" which have yet to be included two or three updates later. In the mentime, users are still suffering from it.

Maybe you might like to have a new status: Resolution In Progress. That way, when it has all filtered through, you can use Resolved. And it will aid in all those posts that appear on the blog that are "Resolved", and then an hour later you say "Er, it's not doing what is expected, and is borked again." They would still be in progress, but people know you are working on it.

That way they would not waste yet more time, money and objects disappearing on something you say is "fixed" when it ain't.


Rob Linden added a comment - 19/Dec/07 11:58 PM
I've done some work on this to create a new workflow. The workflow includes these changes:
1. New "Fix Pending" state
2. Addition of a "meta" state (link to issue would be appreciated)
3. Ability to change the resolution of issues without reopening first

This is probably going to screw up sljirastats.com, so Im giving Gigs the heads up now. Also, I need to run this by Aric and others.


Rob Linden added a comment - 19/Dec/07 11:59 PM
Clarification: I haven't implemented the new workflow, but I've created it. Implementing is disruptive, so I'm going to get reviews first.

Rob Linden made changes - 21/Dec/07 11:41 PM
Workflow jira [ 16642 ] jira-2007-12-19 [ 18964 ]
Rob Linden made changes - 22/Dec/07 12:18 AM
Workflow jira-2007-12-19 [ 18964 ] jira-2007-12-21 [ 19387 ]
Rob Linden made changes - 23/Dec/07 12:42 AM
Workflow jira-2007-12-21 [ 19387 ] jira-2007-12-22a [ 49612 ]
Celierra Darling added a comment - 26/Dec/07 01:35 AM
This seems to have been implemented...? Marking as fixed for now...

Celierra Darling made changes - 26/Dec/07 01:35 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Torley Linden added a comment - 31/Dec/07 09:33 AM
@Celierra: Yes, it has been. Thanks for marking this, and I'm going to do a blog post highlighting these changes for the broader benefit of those who haven't been watching this issue.

Sue Linden made changes - 13/Nov/08 11:56 AM
Workflow jira-2007-12-22a [ 49612 ] jira-2008-11-14 [ 79648 ]
Sue Linden made changes - 13/Nov/08 04:21 PM
Workflow jira-2008-11-14 [ 79648 ] jira-2008-11-14a [ 84635 ]