[#VWR-6858] The HELP panel for Report Abuse window shows its Close button always in English

1. Second Life Viewer - VWR

The HELP panel for Report Abuse window shows its Close button always in English

Created: 25/Apr/08 12:23 AM Updated: 19/Mar/09 11:53 PM

Return to search

Component/s:

Internationalization, User Interface

Affects Version/s:

1.20 Release Candidate, 1.19.0.5, 1.19.1.4, 1.22

Fix Version/s:

None

File Attachments:

close-20080507.diff (6 kB)

Image Attachments:

1. help.png
(13 kB)

Issue Links:

Relates

This issue Relates to:

VWR-6607 Japanese UI translation is out of date.

VWR-6787 The word "none" on a group list appears as the English word "none" and it is unable to translate it through XUI files

VWR-4832 Notifications and Alerts redesign

Last Triaged:	30/Oct/08 04:52 PM
Source Version:	1.20.5.86279
Linden Lab Issue ID:	DEV-14423
Patch attached:	Patch attached
Linden Lab Internal Branch:	maint-viewer-12

Description

« Hide

When you choose "Report abuse", a help panel is automatically appears. It has a "Close" button. The button label is always in English "Close" regardless what UI language the user is using. This is not a simple "forgot to translate" issue. The behaviour is caused by the fact that the underlying C++ program has a hard-coded string "Close" and use that string as the button label, ignoring the user's UI language. It is on line 282 in linden/indra/llui/llalertdialog.cpp in 1.20.2.85278 source. Hence, it is impossible to fix this issue by editing XUI files only. The fix is, however, obvious. This particular string "Close" should be placed in an XUI file (somewhere in alerts.xml, probably), and the viewer program should read that string from one of the translated versions of the XUI files.

A screen shot taken under the German UI is attached. Note that the button label is "Close" but "Abbrechen".

I will provide a patch to fix this issue on the next weekend (3-4 May), if nobody supplied one before then...

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Ramzi Linden added a comment - 01/May/08 04:14 PM

This should be addressed in the Notifications project which is underway at Linden Lab.

[ Permlink | « Hide ]

Alissa Sabre added a comment - 07/May/08 07:39 AM

I produced a patch, close-20080507.diff to fix this issue. It is against the viewer source 1.20 RC5 (1.20.5.86279). Note that the patch contains several UTF-8 texts, and you need Unicode capable tools to handle it.

As a (positive) side effect, this patch makes not just HELP panel for the report abuse but all the lone "Close" buttons (except for one special case which has already translated in RC5) appearing on the alert dialog boxes to have a translated button label.

I produced all eight language XUI files (English + 7 translations.) After applying this patch, the close buttons appear as the following labels:

German: Schliesen
English: Close
Spanish: Cerrar
French: Fermer
Japanese: 閉じる
Korean: 닫기
Portugese: Fechar
Chinese: 关闭

I'm sure the following language versions are OK: English (en-us), Japanese (ja), Korean (ko), and Chinese (zh). However, I'm not sure other translations are appropriate. So, someone needs to review Spanish (es), French (fr), and Portugese (pt) translations before this patch goes into the release viewer.

[ Permlink | « Hide ]

Soft Linden added a comment - 30/Oct/08 11:29 AM

Thanks, Alissa. You're awesome as always

[ Permlink | « Hide ]

Alissa Sabre added a comment - 19/Mar/09 11:53 PM

This issue persists in 1.22.11 viewer.