• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-6540
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Normal Normal
Assignee: Phoenix Linden
Reporter: able whitman
Votes: 37
Watchers: 7
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Add options to selectively render attached lights and attached particle sources

Created: 14/Apr/08 01:13 PM   Updated: 07/Jan/09 04:11 PM
Return to search
Component/s: Avatar/Character
Affects Version/s: Source code, 1.19.1.4
Fix Version/s: None

File Attachments: 1. Text File render.1.20.patch (6 kB)
2. Text File renderattach.patch.txt (7 kB)

Environment: Tested against 1.19.1.4 source on Windows Vista SP1 and Visual Studio 2008
Issue Links:
Duplicate
 
Relates
 

Source Version: 1.19.1.4
Linden Lab Issue ID: DEV-14157
Patch attached: Patch attached
Linden Lab Internal Branch: attachment-spam-diet


 Description  « Hide
== Background ==

Particle sources from attached objects can be annoying or distracting, whether on purpose or accidentally. Similarly, attachments which are light sources can adversely impact the local ambient lighting, particularly in crowded areas where lighted attachments overwhelm the client limit of 6 local light sources.

While it is possible to entirely disable particles and local lights, this is not an optimal solution.

== Details ==

This patch adds two new menu options under the Advanced menu:

  • Advanced > Render > Attached Lights

This option (enabled by default), controls whether or not the viewer will render light sources which are attached to an avatar. When enabled, viewer behavior will remain unchanged, and attached lights will render normally. When disabled, attached lights will not be rendered, and will not be taken into consideration when the viewer decides which 6 light sources to render.

  • Advanced > Render > Attached Particles

This option (also enabled by default) controls whether or not the viewer will render particle sources which are attached to an avatar. Again, it is enabled by default and when enabled does not affect normal particle rendering. When disabled, attached particle sources will not be rendered.

== Notes ==

These options will affect all avatars visible to the user, including the user's avatar.

The state of these options will persist across login sessions.

Only attached objects are affected when either of these options are disabled; if an attached object is dropped on the ground, or taken into inventory and then rezzed unattached, its light source and particle source will again be rendered. Unattached objects are entirely unaffected by these options.



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Jacek Antonelli added a comment - 12/May/08 07:14 AM
Another small-but-profoundly-useful feature. Brilliant.

Phoenix Linden added a comment - 14/May/08 03:25 PM
The patch does not apply cleanly to 1.20+. I translated the declaration of the settings to the new settings.xml. Also, 2 of the diffs for particle system shut-off were unnecessary and could lead to unnecessary load. They were not committed.

Let me know if you want me to post the patch here.


able whitman added a comment - 14/May/08 06:31 PM
Yes, please post the 1.20 patch here. It sounds like you basically re-wrote it, so I hereby bequeath credit for this patch to you Thanks!

Finnella Flanagan added a comment - 17/Aug/08 01:54 PM
This is a great idea. It's a great shame that one person can ruin the surroundings with obnoxious particle spamming or a facelight that resembes a streetlight. I can mute someone who is being rude, but I currently have no recourse with people who are ruining the surroundings visually. Also, I have a medical condtion that responds poorly to excessive particle spam. It would be nice to have an option other than turning off all particles.

gearsawe stonecutter added a comment - 12/Sep/08 06:52 PM
the current option in 1.21.2 does not work like expected. you don't see the worn lights but it still takes away from the surrounding light source count. wear 8 light sources with this option you will notice any lights about still don't work. It is as if the light you are wearing are set to black so they don't show but still count.

Phoenix Linden added a comment - 15/Sep/08 09:09 AM
The (modified) patch incorporated into the viewer only flips some bits during render. If you feel strongly about this, submit a new bug or propose a patch to the current source.

Harmony Deschanel added a comment - 27/Sep/08 11:55 PM
Ok Pheonix it looks like that's been done here at this Jira http://jira.secondlife.com/browse/VWR-6058

Jacek Antonelli added a comment - 28/Sep/08 09:34 AM
I've opened VWR-9393 to address disabled attached lights counting towards the 6 light limit. VWR-6058 was created before this one (VWR-6540), and is essentially the same as the light-related part of this, so I don't think it would be appropriate to repurpose an older issue.