• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-5963
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Normal Normal
Assignee: Unassigned
Reporter: Carjay McGinnis
Votes: 2
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

LLImageGL::setClamp may affect random texture (making repeating textures on objects non-repeating)

Created: 31/Mar/08 03:16 PM   Updated: 24/Jul/08 03:01 PM
Return to search
Component/s: Graphics, Source Code
Affects Version/s: Source code
Fix Version/s: 1.20

File Attachments: None
Image Attachments:

1. clamped.jpg
(37 kB)

2. repeating.jpg
(44 kB)
Environment:
Kubuntu Feisty x86_64 Linux
Issue Links:
Duplicate
 
Relates

Linden Lab Issue ID: DEV-12982


 Description  « Hide
I noticed a weird effect with repeating textures on objects. Sometimes, seemingly out of nowhere one or more textures would stop repeating and were simply clamped to the edge.

I traced this down to LLImageGL::setClamp being out of sync with the currently bound texture.

There are several places in the code that treat setClamp as if it was a kind of property-function while internally it assumes that a) either the texture was not created yet (mTexName is 0), so it won't try to set it up or b) that the texture is created AND bound. But the last assumption is not always valid.

Since most of the time textures are loaded "repeating" you will only notice a "miss" if e.g. the Notify-Box pops up (when another avatar logs on ) and a repeating texture is bound at the same time. In this case chances are high, an "Edge"-texture clamp is set up which might influence some random texture.

It's not a severe issue but can be a bit distracting at times.

I was thinking about providing a patch but this is probably better addressed by one of the graphics guys since it requires a design decision about what to do with the setClamp-method.



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Carjay McGinnis added a comment - 31/Mar/08 05:21 PM
attached two screenshots to illustrate the visual effect

Gellan Glenelg added a comment - 21/May/08 06:49 PM
Fixed in 1.20.7 (87883)

Winter Ventura added a comment - 19/Jul/08 11:26 PM
"Fix Pending" until fix is released in official client.