• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-5929
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Normal Normal
Assignee: Ramzi Linden
Reporter: Alissa Sabre
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Some UI translation texts are ignored because of missing names in XUI files

Created: 30/Mar/08 02:03 AM   Updated: 07/Oct/08 02:58 PM
Return to search
Component/s: Internationalization, User Interface
Affects Version/s: 1.20 Release Candidate, 1.19.1 Release Candidate, 1.21 Release Candidate
Fix Version/s: 1.20 Release Candidate, 1.21 Release Candidate

File Attachments: 1. Text File 1.20.0-xui-missing.patch (39 kB)
2. Text File missingnames.patch (26 kB)
3. Text File missingnames.txt (2 kB)

Issue Links:
Relates

Source Version: 1.19.1.4, 1.20.0.84432
Linden Lab Issue ID: DEV-21656
Patch attached: Patch attached
Linden Lab Internal Branch: viewer-1-21


 Description  « Hide
SL viewer uses language specific XUI files for UI translation. Enlgish (en-us) version acts as a base UI definition, and language versions (e.g., fr, de, ja, ...) supply translated texts. English texts in en-us version and translated texts in language versions are matched with "name" attributes given to UI definition elements.

In the current SL viewer's English XUI files, some UI elements that contains translatable texts lack "name" attributes. They cause corresponding translation texts silently ignored.

This issue is originally reported by Geneko Nemeth as a comment to VWR-4125. I'm creating a separate issue, because (1) "duplicate names" and "missing names" are similar but separate problems in XUI files, and (2) VWR-4125 is fixed in 1.19.1 viewer although this "missing names" issue is not.

I'm now producing a complete list of missing names based on the 1.19.1 RC(4) viewer. I'm uploading it when ready.



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Alissa Sabre added a comment - 30/Mar/08 08:23 AM - edited
I uploaded two files: missingnames.txt and missingnames.patch.

missingnames.txt lists all elements whose necessary name attributes are missing. It lists an elemet per a line in three fields. Each line has the following format:

file:line:element

where

file is the name of the XUI (.xml) file that contains the element,
line is the line number in the file at which the element's start tag presents, and
element is the name (GI) of the element.

Note that an element's start tag can span multiple lines. The line number above is of the last line in the case.

missingnames.patch is the patch (diff from the original) to fix this issue, adding names to the elements. The names are chosen arbitrarily.


Alissa Sabre added a comment - 11/Apr/08 08:38 AM
This issue persists in 1.19.0.84432 RC.

I produced an updated patch file to fix this issue. It is against 1.19.0.84432 RC.


Ramzi Linden added a comment - 11/Apr/08 06:26 PM
Thanks for posting these! Obviously, we did not manage to integrate them into Viewer 1.19.1. However I have just committed them to the branch for Viewer 1.20, and they should appear in the next RC.

With the following exceptions:

  • floater_joystick.xml met with conflicts due to a large number of revisions to that file; therefore this name change has been discarded for another (Along with many new names for a number of added elements as well.)
  • panel_settings_. These seem to be legacy files not referenced in the viewer and were therefore omitted.

Alissa Sabre added a comment - 11/Apr/08 07:00 PM
Thank you for the quick reaction, Ramzi. Can you please removed those unused XUI files both from binary distribution and from the source repository if not yet?

Alissa Sabre added a comment - 16/Apr/08 04:45 AM
Cofirmed fix in 1.20.0.84760 (RC1). Thank you for the quick fix!

Geneko Nemeth added a comment - 30/Sep/08 07:06 PM - edited
panel_region_debug.xml in 1.21.3 has a couple of <text /> that don't have a name. Reopening issue.

Geneko Nemeth added a comment - 30/Sep/08 07:07 PM
Updating affected version

Ramzi Linden added a comment - 01/Oct/08 12:13 PM
Thanks for catching those omissions, Geneko. We'll track this again and fix it.

Rob Linden added a comment - 02/Oct/08 08:43 AM
Should be fixed in RC5

Ramzi Linden added a comment - 07/Oct/08 02:58 PM
This should now appear fixed in RC5. Note, the additional translations are not yet in place; but the name= parameters now exist in the primary EN-US files, which make translation possible.