• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-5812
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Qarl Linden
Reporter: anthony reisman
Votes: 7
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

RC: A media size matching a bit position (64,128,256,512) will be placed on the wrong size texture when played by the viewer

Created: 23/Mar/08 07:03 AM   Updated: 20/Apr/08 11:25 AM
Return to search
Component/s: Graphics, Scripting
Affects Version/s: 1.19.1 Release Candidate
Fix Version/s: 1.20 Release Candidate

Issue Links:
Relates

Linden Lab Issue ID: DEV-12660
Linden Lab Internal Branch: Branch_1-20-Viewer


 Description  « Hide
This only applies to the RC and I believe is the actual problem with regards to SVC-1832.

See SVC-1832 for pictures and more background information

In short if the viewer tries to play media at exactly 512, the media will be distorted because it will choose the next higher texture for placement. However if the media is 511 or 513, then it is played correctly.

I believe at least part of the problem may be in llmediamanager.cpp but I have not been able to build the client viewer successfully yet.

The area of code is near the end with the following while loop:

while ( texture_width < media_width )
{
texture_width <<= 1;
};

I believe if it is changed to
while ( texture_width <= media_width )
{
texture_width <<= 1;
};

then it may be fixed



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
anthony reisman added a comment - 23/Mar/08 07:03 AM
linked the two issues.

Mana Janus added a comment - 29/Mar/08 11:24 AM
Just verified that this bug occurs for other powers of 2 as well, as the described patch suggests.

anthony reisman added a comment - 09/Apr/08 04:18 PM
Linked an issue that can cause similar symptoms.

anthony reisman added a comment - 20/Apr/08 08:55 AM
I have verified that in RC 1.20.2, this is fixed. images and smil files that are on a power of 2 boundary now play correctly.

Thanks Qarl for jumping on this!!!!!


Qarl Linden added a comment - 20/Apr/08 11:25 AM
my pleasure Anthony. let me know if it gives you any more grief.