• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-53
Type: Bug Bug
Status: Fix Pending Fix Pending
Priority: Normal Normal
Assignee: WorkingOnIt Linden
Reporter: Joannah Cramer
Votes: 11
Watchers: 7
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Inconsistency in order of AV texture layers between the upper body, lower body, and head

Created: 20/Jan/07 08:19 AM   Updated: 28/Apr/09 03:33 PM
Return to search
Component/s: Avatar/Character
Affects Version/s: 1.13.1.5
Fix Version/s: 1.17.3, 1.19.1.4

File Attachments: 1. XML File avatar_lad.xml (255 kB)
2. XML File avatar_lad.xml (255 kB)
3. Text File avatar_lad.xml.patch (0.9 kB)
4. Text File avatar_lad.xml.patch (6 kB)

Image Attachments:

1. No_Unwanted_MakeUp.png
(102 kB)

2. screenshot-1.jpg
(137 kB)

3. Unwanted_MakeUp.png
(191 kB)
Issue Links:
Relates
 

Last Triaged: 09/Oct/08 06:29 PM
Linden Lab Issue ID: DEV-1189
Patch attached: Patch attached
Linden Lab Internal Branch: avatar-pipeline-7


 Description  « Hide
File ./character/avatar_lad.xml defines texture layer sets for the avatar. The order of freckles and bodypaint layers for upper body is reversed when compared to order of the same layers for the lower body. The result is, if avatar is wearing custom skin which utilizes the bodypaint layer, moving the Skin -> Body Detail -> Body Freckles slider from 0 value creates visible freckles on the bottom part of the AV but not on the torso. In addition the upper body freckles layer has wrong texture assigned to it.

Fix:

Change the reference to "bodyfreckles_alpha.tga" in line 6609 to "upperbodyfreckles_alpha.tga" (the file is already shipped as part of the client, but due to wrong reference it's not utilized)

Move the definition of "upper_bodypaint" layer (lines 6615-6620) before the definition of "freckles upper" layer (line 6598) to match the order of lower body layers.



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Lex Neva added a comment - 20/Jan/07 09:04 PM
Nice catch. Maybe attach a fixed version of avatar_lad.xml and/or a patch file?

Joannah Cramer added a comment - 21/Jan/07 03:59 PM
fixed version of the avatar_lad.xml file from client version 1.13.2 (12)

Joannah Cramer added a comment - 21/Jan/07 04:09 PM
OK, i've added fixed version of the file which is distributed with the current client... i didn't keep the original so can't make the patch file at this point, am afraid :|

Ryozu Kojima added a comment - 15/Feb/07 08:24 PM
Thanks to Joannah Cramer for the information on where to fix this issue.
Joannah's initial fix fixed the freckles on the upper body worked fine, but I wanted to fix a few other inconsistencies in the order that avatar layers are rendered, including facial freckles as well. So I went over all the layers and reordered some of them to be more logical.

Ryozu Kojima added a comment - 15/Feb/07 08:59 PM
Well, doh. Sorry about the last upload (File 2...)
I stuck a comment at the top of the file, which apparently causes SL to crash on login.

So here's the file with that taken out.

I did notice one other bug with this file, in the Edit Appearance window, the head now appears semi-transparent. I can't figure out why the heck this is, anyone else have ideas?


Ryozu Kojima added a comment - 15/Feb/07 09:53 PM
My head hurts.. ;_;
Okay, so the problem seems to be on lines 5511 and 5512
clear_alpha="false"
alpha_tga_file="head_alpha.tga">
This sets the alpha so the eyelashes render properly. Question is, why would this cause transparent heads in the appearance editor?

Ryozu Kojima added a comment - 16/Feb/07 05:26 PM
Here is the patch file to change the main viewer 1.13.2 (2) avatar_lad.xml file into the fixed avatar_lad.xml file. This changes the order in which the avatar layers are baked to be more consistent, and allows some layers to be baked on top of layers they previously were not, allowing more options for avatar customization.

Known Issue:
Second Life 1.13.3 (58018) (First Look) has one issue: In the Appearance editor, the preview snapshots render the avatar's head region as partially transparent.


Soft Linden added a comment - 15/Jun/07 10:12 AM
Thank you so much - gettin' this one in

Torley Linden added a comment - 06/Jul/07 09:01 AM

Ryozu Kojima added a comment - 12/Jul/07 12:22 PM
Reopening issue as this doesn't appear to be fixed in SL 1.18.0(6)

Ryozu Kojima added a comment - 12/Jul/07 12:25 PM
As you can see, with the skin tattoo layers set to a plain white texture, set "Freckles" to 100 under both Face Detail and Body Detail, the freckles appear only on the lower body.
This is only one example of the many differences in the ordering of the layers on each section of the body.

Joannah Cramer added a comment - 30/Jul/07 08:28 PM
I've looked into it and it appears the avatar_lad.xml file in version 1.18 while nicely cleaned up and whatnot... re-introduces the same layer order that was present in old versions of the viewer.

Will try to attach new patch file shortly.


Soft Linden added a comment - 17/Sep/07 10:56 AM
Do me a favor and ping me in-world when you upload the change and I'll make sure we give it a try. The last go around, there were some conflicts between the appearance editor and how the textures were baked on the avatar.

Soft Linden added a comment - 31/Oct/07 07:27 PM
There's some tougher stuff here that breaks the texture previews - pushed back to triage for a graphics specialist

Joannah Cramer added a comment - 13/Apr/08 04:24 PM - edited
patch file for avatar_lad.xml v. 1.19.1 (4)

simplified version of the fix, repairs the inconsictency of freckle layers without breaking the appearance preview.

( this version of the patch doesn't touch current order of the head layers, thus does not cause translucent rendering of the head in appearance window. The placement of freckles layer for both upper and lower body now matches each other, as well as placement of face freckles layer on AV head. Having the freckles rendered before the 'tattoo' layer allows custom skin makers – through alpha channel of their skin texture-- to have additional control over intensity and areas of the body freckles. Fully opaque custom skin will cover these freckles entirely, but they can be 'seen through' in places where alpha channel of the custom skin is set to high enough value.

Alternative approach i.e. placing the freckles layer after the tattoo layer in render order ... would make the freckles always show fully over custom skin which could be desirable behaviour, but it didn't match the order of freckles and custom tattoo layer on the face, and fixing that to match was likely to cause earlier issues with translucent render in appearance window. Hence opted for the other way)


Q Linden added a comment - 09/Oct/08 01:22 PM
This is in the hands of a team reworking some of the avatar code.

Rob Linden added a comment - 06/Dec/08 11:58 AM
This was checked into a branch a while back, and with any luck, should be landing in the trunk soon. This won't make it into the 1.22 release, but maybe the next viewer release after that.

Mm Alder added a comment - 04/Jan/09 01:19 PM
Right now the tattoo layer is over the eyebrows and facial hair, so the Appearance sliders for these appear to do nothing. This is more of a problem now that the default avatars given to new residents have custom skins on the tattoo layer. See VWR-10319 and VWR-8195, for example.

Boroondas Gupte added a comment - 22/Mar/09 10:28 AM - edited
The changes which hit trunk recently (I guess in http://svn.secondlife.com/svn/linden/trunk@1881, but I'm not sure) seem to have some implications for no-mod skins. Some skin creators which use fully opaque "tattoo" textures to override the base skin didn't bother to set the make up sliders to zero, as the make up was completely covered by the "tattoo" layer anyway. (See attached No_Unwanted_MakeUp.png)

With the layers reordered, these (often interfering) make ups will now appear and, in the case of no-mod skins, cannot be removed by the user, because the make up, too is a property of the skin. (See attached Unwanted_MakeUp.png)

(Note that the double eye brows aren't a problem, because they're part of the (built in) hair, which – as commercially made hair is often prim hair – is rarely no-mod, so they usually can be removed by the user)