• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-4331
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Duplicate
Priority: Normal Normal
Assignee: Tofu Linden
Reporter: Michelle2 Zenovka
Votes: 2
Watchers: 4
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR
VWR-2662

Implement Wind Noise with OpenAL

Created: 23/Jan/08 10:16 AM   Updated: 16/Sep/08 09:59 AM
Return to search
Component/s: Sound
Affects Version/s: Source code
Fix Version/s: None

File Attachments: 1. Text File windpatch.patch (8 kB)

Environment: Any
Issue Links:
Relates


 Description  « Hide
To be feature complete w.r.t FMOD we should implement the wind noise in using OpenAL. This sub task is to keep the windnoise out of the way of the main openAL discussion. Patches to follow (soonish)

 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Michelle2 Zenovka added a comment - 23/Jan/08 11:21 AM
Attached is my latest effort at wind noise. Please note this patch is applied on top of the patches listed in the parent task.

The wind basically works but openAL seems to have a transient "click" on each buffer played. This is the same as reported by Soft previously with openAL playback. No idea of the cause yet.

The code is far from clean. There are some static global variables defined. These should be moved to class variables where possible.

There are magic numbers for sample frequency, number of buffers, length of buffer etc. Reduce magic number usage where we can.

The audio itself does not sound quite right, some of it may be due to the length and the number of buffers. This seems to be a balance between having enough buffers to maintain playback but manage to keep responsiveness up on wind changes. The current buffer system is very basic and probably could be improved.

Anyway its a start


Michelle2 Zenovka added a comment - 01/Feb/08 03:36 PM
Ok i have a working wind generator now, no clicks or pops and does pretty much everyhing the old one did. Just lacking independent volume as i cannot see where that is set. Will post update here soon

Gigs Taggart added a comment - 02/Mar/08 08:28 PM
My recent profiling has shown the old windCallback was using 5% of all CPU time, making it one of the top functions.

Is this new implementation faster?


Tofu Linden added a comment - 16/Sep/08 09:59 AM
Rolled into VWR-2662 (thanks) and refactored.