History | Log In     View a printable version of the current page.  
  • All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you've read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-427
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Normal Normal
Assignee: Soft Linden
Reporter: Jacek Antonelli
Votes: 6
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Added new menu item: Tools > Edit Linked Parts

Created: 10/Apr/07 02:42 PM   Updated: 27/Jun/07 11:53 AM
Component/s: Building (in-world), User Interface
Affects Version/s: Source code
Fix Version/s: 1.17.1

File Attachments: 1. Text File edit_linked_parts.patch (16 kb)

Issue Links:
Relates
 

Source Version: patch generated against FL-1.13.3.58390
Linden Lab Issue ID: SL-41454
Patch attached: Patch attached


 Description  « Hide
I've attached a patch to add a new entry to the Tools menu: a toggle switch for the "Edit Linked Parts" behavior (allowing the user to select and edit individual prims from a linked object). This allows the exciting possibility of binding a keyboard shortcut to this oft-used building feature! (For my own use, I bound it to the semicolor key, a personally convenient location with the keyboard layout I use. In the patch, I have left it unbound.)

In the process of adding the menu entry, I changed the control name (setting) used to store the toggle state of that behavior:
 - Previously, it was the "SelectLinkedSet" control. When this was true, you would select the entire linked object, not it's parts. So, the state of this control was always the opposite of the state of the "Edit Linked Parts" checkbox.
 - Now, it is the "EditLinkedParts" control. The state of the control directly reflects the state of the checkbox.

I manually replaced all instances of SelectLinkedSet with EditLinkedParts throughout the client code, adjusting the code to take into account the semantic difference. I doubt there are any references to SelectLinkedSet in the server portion (since it's a client-specific feature), but if so, they should be changed on Linden Lab's end.

I also duplicated the selection-promotion/-demotion code for the Tools floater (llfloatertools.cpp) into the viewer menus (llviewermenu.cpp). That code modifies the selection when toggling EditLinkedParts: select the entire object when promoting the selection (disabling ELP), or select the individual parts when demoting (enabling ELP). Without this, the behavior of the new menu item wouldn't be consistent with the behavior of the checkbox in the Tools floater. There may be a cleaner way than copying code from one file into the other; perhaps calling the original function from the other file.

One last note: I've only updated the en-us versions of menu_viewer.xml and floater_tools.xml (for my own use). Other localizations still need to be updated to include the new menu item, and to use the correct control name!

 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Gigs Taggart - 10/Apr/07 06:18 PM
Cool!

Torley Linden - 11/Apr/07 08:46 AM
I like learning about these tweaks you've been making, Jacek!

McCabe Maxsted - 31/May/07 09:13 PM
Very cool. I've been longing for a keyboard shortcut for "edit linked parts" ever since I first started building (and discovered what a pain the checkbox can be at times).

Soft Linden - 15/Jun/07 10:14 AM
Easy enough - in it goes!